Bug 1539255 - Back out new tab animations. r=dao a=pascalc
authorFelipe Gomes <felipc@gmail.com>
Wed, 27 Mar 2019 14:55:13 +0000
changeset 525815 d511bf7fa222cfac860067f72bb11c6691b50a20
parent 525814 d7c011c3dd7f589362c64829a28f7f42991937c5
child 525816 dba7de840829244c8978c16dfc4a7123aaa19610
push id2032
push userffxbld-merge
push dateMon, 13 May 2019 09:36:57 +0000
treeherdermozilla-release@455c1065dcbe [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdao, pascalc
bugs1539255
milestone67.0
Bug 1539255 - Back out new tab animations. r=dao a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D24964
browser/app/profile/firefox.js
browser/base/content/browser.css
browser/base/content/tabbrowser.xml
--- a/browser/app/profile/firefox.js
+++ b/browser/app/profile/firefox.js
@@ -473,19 +473,16 @@ pref("browser.tabs.extraDragSpace", fals
 // true   return to the tab that opened this tab (its owner)
 // false  return to the adjacent tab (old default)
 pref("browser.tabs.selectOwnerOnClose", true);
 
 pref("browser.tabs.showAudioPlayingIcon", true);
 // This should match Chromium's audio indicator delay.
 pref("browser.tabs.delayHidingAudioPlayingIconMS", 3000);
 
-// New, experimental, tab open/close animations.
-pref("browser.tabs.newanimations", false);
-
 // Pref to control whether we use separate privileged content processes.
 #if defined(NIGHTLY_BUILD) && !defined(MOZ_ASAN)
 pref("browser.tabs.remote.separatePrivilegedContentProcess", true);
 #endif
 
 // Turn on HTTP response process selection.
 pref("browser.tabs.remote.useHTTPResponseProcessSelection", true);
 
--- a/browser/base/content/browser.css
+++ b/browser/base/content/browser.css
@@ -171,34 +171,16 @@ panelview[mainview] > .panel-header {
               max-width 100ms ease-out;
 }
 
 :root[uidensity=touch] .tabbrowser-tab:not([pinned]) {
   /* Touch mode needs additional space for the close button. */
   min-width: calc(var(--tab-min-width) + 10px);
 }
 
-@supports -moz-bool-pref("browser.tabs.newanimations") {
-
-.tabbrowser-tab:not([pinned]):not([tabdrop-samewindow]) {
-  transition: transform 100ms ease-in-out;
-}
-
-#tabbrowser-tabs[movingtab] > .tabbrowser-tab[selected] {
-  transition: none;
-}
-
-.tabbrowser-tab:not([pinned]):not([fadein]) {
-  transform: translateY(var(--tab-min-height));
-}
-
-} /* end @supports -moz-bool-pref("browser.tabs.newanimations") */
-
-@supports not -moz-bool-pref("browser.tabs.newanimations") {
-
 .tabbrowser-tab:not([pinned]):not([fadein]) {
   max-width: 0.1px;
   min-width: 0.1px;
   visibility: hidden;
 }
 
 .tab-icon-image[fadein],
 .tab-close-button[fadein],
@@ -216,18 +198,16 @@ panelview[mainview] > .panel-header {
   visibility: hidden;
 }
 
 .tab-label:not([fadein]),
 .tab-throbber:not([fadein]) {
   display: none;
 }
 
-} /* end @supports not -moz-bool-pref("browser.tabs.newanimations") */
-
 %ifdef NIGHTLY_BUILD
 @supports -moz-bool-pref("browser.tabs.hideThrobber") {
   .tab-throbber {
     display: none !important;
   }
 }
 %endif
 
--- a/browser/base/content/tabbrowser.xml
+++ b/browser/base/content/tabbrowser.xml
@@ -1232,29 +1232,21 @@
 
       <handler event="TabShow"><![CDATA[
         if (event.target.soundPlaying) {
           this._hiddenSoundPlayingStatusChanged(event.target);
         }
       ]]></handler>
 
       <handler event="transitionend"><![CDATA[
-        if (event.propertyName != "max-width" &&
-            event.propertyName != "transform") {
+        if (event.propertyName != "max-width") {
           return;
         }
 
-        if (gBrowser.tabAnimationsInProgress == 0) {
-          return;
-        }
-
-        let tab = event.originalTarget;
-        if (tab.nodeName != "tab") {
-          return;
-        }
+        let tab = event.target;
 
         if (tab.getAttribute("fadein") == "true") {
           if (tab._fullyOpen) {
             this._updateCloseButtons();
           } else {
             this._handleNewTab(tab);
           }
         } else if (tab.closing) {