bug 1343686 log a message if xpinstall.signatures.dev-root is set and install fails r=aswan
authorandy mckay <amckay@mozilla.com>
Wed, 01 Mar 2017 16:22:38 -0800
changeset 394553 d4ce6c0007c2a7e6e26033c1c85f893e30ff243b
parent 394552 ece3e5e5f0f0646f7a3a2aaf6809d0efbe8a998d
child 394554 11eb095a371528eabfd3efbbe57c80c67fd5f58c
push id1468
push userasasaki@mozilla.com
push dateMon, 05 Jun 2017 19:31:07 +0000
treeherdermozilla-release@0641fc6ee9d1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersaswan
bugs1343686
milestone54.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
bug 1343686 log a message if xpinstall.signatures.dev-root is set and install fails r=aswan MozReview-Commit-ID: 6zA9rjBXyQf
toolkit/mozapps/extensions/internal/XPIProvider.jsm
--- a/toolkit/mozapps/extensions/internal/XPIProvider.jsm
+++ b/toolkit/mozapps/extensions/internal/XPIProvider.jsm
@@ -759,16 +759,19 @@ function canRunInSafeMode(aAddon) {
  */
 function isUsableAddon(aAddon) {
   // Hack to ensure the default theme is always usable
   if (aAddon.type == "theme" && aAddon.internalName == XPIProvider.defaultSkin)
     return true;
 
   if (mustSign(aAddon.type) && !aAddon.isCorrectlySigned) {
     logger.warn(`Add-on ${aAddon.id} is not correctly signed.`);
+    if (Preferences.get(PREF_XPI_SIGNATURES_DEV_ROOT, false)) {
+      logger.warn(`Preference ${PREF_XPI_SIGNATURES_DEV_ROOT} is set.`);
+    }
     return false;
   }
 
   if (aAddon.blocklistState == Blocklist.STATE_BLOCKED) {
     logger.warn(`Add-on ${aAddon.id} is blocklisted.`);
     return false;
   }