Bug 1510580 - Remove browser.fixup.hide_user_pass pref, r=valentin
authorAndrea Marchesini <amarchesini@mozilla.com>
Wed, 28 Nov 2018 18:05:55 +0100
changeset 507824 d43ea215cceebe13bf68fde77dc75fc91c94d1dc
parent 507823 3241939e39a97dbda57305bf96a4ea1d72fcd5df
child 507825 037b1d961ac53610890b6cb3dcc6ac81ad7ce008
push id1905
push userffxbld-merge
push dateMon, 21 Jan 2019 12:33:13 +0000
treeherdermozilla-release@c2fca1944d8c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersvalentin
bugs1510580
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1510580 - Remove browser.fixup.hide_user_pass pref, r=valentin
docshell/base/nsDefaultURIFixup.cpp
modules/libpref/init/all.js
--- a/docshell/base/nsDefaultURIFixup.cpp
+++ b/docshell/base/nsDefaultURIFixup.cpp
@@ -74,22 +74,19 @@ nsDefaultURIFixup::CreateExposableURI(ns
   if (isWyciwyg) {
     nsresult rv = nsContentUtils::RemoveWyciwygScheme(aURI, getter_AddRefs(uri));
     NS_ENSURE_SUCCESS(rv, rv);
   } else {
     // No need to clone the URI as NS_MutateURI does that for us.
     uri = aURI;
   }
 
-  // hide user:pass unless overridden by pref
-  if (Preferences::GetBool("browser.fixup.hide_user_pass", true)) {
-    Unused << NS_MutateURI(uri)
-                .SetUserPass(EmptyCString())
-                .Finalize(uri);
-  }
+  Unused << NS_MutateURI(uri)
+              .SetUserPass(EmptyCString())
+              .Finalize(uri);
 
   uri.forget(aReturn);
   return NS_OK;
 }
 
 NS_IMETHODIMP
 nsDefaultURIFixup::CreateFixupURI(const nsACString& aStringURI,
                                   uint32_t aFixupFlags,
--- a/modules/libpref/init/all.js
+++ b/modules/libpref/init/all.js
@@ -1164,17 +1164,16 @@ pref("layout.framevisibility.numscrollpo
 // 1 and higher - slider thickness multiple
 pref("slider.snapMultiplier", 0);
 
 // URI fixup prefs
 pref("browser.fixup.alternate.enabled", true);
 pref("browser.fixup.alternate.prefix", "www.");
 pref("browser.fixup.alternate.suffix", ".com");
 pref("browser.fixup.dns_first_for_single_words", false);
-pref("browser.fixup.hide_user_pass", true);
 
 // Print header customization
 // Use the following codes:
 // &T - Title
 // &U - Document URL
 // &D - Date/Time
 // &P - Page Number
 // &PT - Page Number "of" Page total