Bug 1504659 Part 5: Update Android reftest expectations. r=botond
authorBrad Werth <bwerth@mozilla.com>
Wed, 16 Jan 2019 21:58:27 +0000
changeset 514157 d3d3222460fce87fc3dc53bdfd9794059b447c06
parent 514156 ddc9999232d6692a0bd58d10e9a5b3dad77562c0
child 514158 8d4aa37d713744c3b6713c0c5fa3cecef535ee74
push id1953
push userffxbld-merge
push dateMon, 11 Mar 2019 12:10:20 +0000
treeherdermozilla-release@9c35dcbaa899 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbotond
bugs1504659, 1133905, 1242172
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1504659 Part 5: Update Android reftest expectations. r=botond The tests for Bug 1133905 all compare the visibility of scrollbars with differently-sized css viewports. This patch has some affect on the viewport sizing that I don't understand, and it causes some of the tests to start passing and some to start failing. The test for Bug 1242172 has elements sized to height 100% and checking for the presence or absence of scrollbars. In this case the patch appears to increase the css viewport height and decrease the width -- again for reasons I don't understand -- and this affects the scrollbar sizes. Differential Revision: https://phabricator.services.mozilla.com/D16078
gfx/layers/apz/test/reftest/reftest.list
layout/reftests/bugs/reftest.list
layout/reftests/transform/compound-1-ref.html
layout/reftests/transform/compound-1a.html
layout/reftests/transform/reftest.list
--- a/gfx/layers/apz/test/reftest/reftest.list
+++ b/gfx/layers/apz/test/reftest/reftest.list
@@ -16,17 +16,18 @@ fuzzy-if(Android,0-45,0-27) skip-if(!And
 # Test scrollbars working properly with pinch-zooming, i.e. different document resolutions.
 # As above, the end of the scrollthumb won't match perfectly, but the bulk of the scrollbar should be present and identical.
 fuzzy-if(Android,0-54,0-14) skip-if(!Android) pref(apz.allow_zooming,true) == scrollbar-zoom-resolution-1.html scrollbar-zoom-resolution-1-ref.html
 fuzzy-if(Android,0-51,0-22) skip-if(!Android) pref(apz.allow_zooming,true) == scrollbar-zoom-resolution-2.html scrollbar-zoom-resolution-2-ref.html
 
 # Meta-viewport tag support
 skip-if(!Android) pref(apz.allow_zooming,true) == initial-scale-1.html initial-scale-1-ref.html
 
-skip-if(!asyncPan) == frame-reconstruction-scroll-clamping.html frame-reconstruction-scroll-clamping-ref.html
+# Bug 1520320 is tracking the effort to make this test pass again.
+skip-if(!asyncPan) fails-if(Android) == frame-reconstruction-scroll-clamping.html frame-reconstruction-scroll-clamping-ref.html
 
 # Test that position:fixed and position:sticky elements are attached to the
 # layout viewport.
 #
 # We skip these tests on Desktop platforms since they require container
 # scrolling, which is enabled by default on Android, but behind a "Once" pref
 # and cannot be enabled for individual reftests.
 skip-if(!Android) pref(apz.allow_zooming,true) == pinch-zoom-position-fixed.html pinch-zoom-position-fixed-ref.html
--- a/layout/reftests/bugs/reftest.list
+++ b/layout/reftests/bugs/reftest.list
@@ -1908,57 +1908,57 @@ skip-if(verify) == 1121748-2.html 112174
 == 1130231-2-button-padding-rtl.html 1130231-2-button-padding-rtl-ref.html
 # The 1133905-*.html reftests only make sense on platforms where both APZ and
 # <meta viewport> are enabled.
 # (Note: bug 1308702 covers these tests' failures on Android)
 skip-if(!Android) == 1133905-1.html 1133905-ref.html
 skip-if(!Android) == 1133905-2.html 1133905-ref.html
 skip-if(!Android) == 1133905-3.html 1133905-ref.html
 skip-if(!Android) == 1133905-4.html 1133905-ref.html
-skip-if(!Android) == 1133905-5.html 1133905-ref.html
-skip-if(!Android) == 1133905-6.html 1133905-ref.html
-skip-if(!Android) fails-if(Android) == 1133905-1-v.html 1133905-ref-v.html
-skip-if(!Android) fails-if(Android) == 1133905-2-v.html 1133905-ref-v.html
-skip-if(!Android) fails-if(Android) == 1133905-3-v.html 1133905-ref-v.html
+skip-if(!Android) fails-if(Android) == 1133905-5.html 1133905-ref.html
+skip-if(!Android) fails-if(Android) == 1133905-6.html 1133905-ref.html
+skip-if(!Android) == 1133905-1-v.html 1133905-ref-v.html
+skip-if(!Android) == 1133905-2-v.html 1133905-ref-v.html
+skip-if(!Android) == 1133905-3-v.html 1133905-ref-v.html
 skip-if(!Android) == 1133905-4-v.html 1133905-ref-v.html
 skip-if(!Android) fails-if(Android) == 1133905-5-v.html 1133905-ref-v.html
 skip-if(!Android) fails-if(Android) == 1133905-6-v.html 1133905-ref-v.html
 skip-if(!Android) == 1133905-1-h.html 1133905-ref-h.html
 skip-if(!Android) == 1133905-2-h.html 1133905-ref-h.html
 skip-if(!Android) == 1133905-3-h.html 1133905-ref-h.html
 skip-if(!Android) == 1133905-4-h.html 1133905-ref-h.html
-skip-if(!Android) == 1133905-5-h.html 1133905-ref-h.html
-skip-if(!Android) == 1133905-6-h.html 1133905-ref-h.html
-skip-if(!Android) fails-if(Android) == 1133905-1-vh.html 1133905-ref-vh.html
-skip-if(!Android) fails-if(Android) == 1133905-2-vh.html 1133905-ref-vh.html
-skip-if(!Android) fails-if(Android) == 1133905-3-vh.html 1133905-ref-vh.html
+skip-if(!Android) fails-if(Android) == 1133905-5-h.html 1133905-ref-h.html
+skip-if(!Android) fails-if(Android) == 1133905-6-h.html 1133905-ref-h.html
+skip-if(!Android) == 1133905-1-vh.html 1133905-ref-vh.html
+skip-if(!Android) == 1133905-2-vh.html 1133905-ref-vh.html
+skip-if(!Android) == 1133905-3-vh.html 1133905-ref-vh.html
 skip-if(!Android) == 1133905-4-vh.html 1133905-ref-vh.html
 skip-if(!Android) fails-if(Android) == 1133905-5-vh.html 1133905-ref-vh.html
 skip-if(!Android) fails-if(Android) == 1133905-6-vh.html 1133905-ref-vh.html
 skip-if(!Android) == 1133905-1-rtl.html 1133905-ref-rtl.html
 skip-if(!Android) == 1133905-2-rtl.html 1133905-ref-rtl.html
 skip-if(!Android) == 1133905-3-rtl.html 1133905-ref-rtl.html
 skip-if(!Android) == 1133905-4-rtl.html 1133905-ref-rtl.html
-skip-if(!Android) == 1133905-5-rtl.html 1133905-ref-rtl.html
-skip-if(!Android) == 1133905-6-rtl.html 1133905-ref-rtl.html
-skip-if(!Android) fails-if(Android) == 1133905-1-v-rtl.html 1133905-ref-v-rtl.html
-skip-if(!Android) fails-if(Android) == 1133905-2-v-rtl.html 1133905-ref-v-rtl.html
-skip-if(!Android) fails-if(Android) == 1133905-3-v-rtl.html 1133905-ref-v-rtl.html
+skip-if(!Android) fails-if(Android) == 1133905-5-rtl.html 1133905-ref-rtl.html
+skip-if(!Android) fails-if(Android) == 1133905-6-rtl.html 1133905-ref-rtl.html
+skip-if(!Android) == 1133905-1-v-rtl.html 1133905-ref-v-rtl.html
+skip-if(!Android) == 1133905-2-v-rtl.html 1133905-ref-v-rtl.html
+skip-if(!Android) == 1133905-3-v-rtl.html 1133905-ref-v-rtl.html
 skip-if(!Android) == 1133905-4-v-rtl.html 1133905-ref-v-rtl.html
 skip-if(!Android) fails-if(Android) == 1133905-5-v-rtl.html 1133905-ref-v-rtl.html
 skip-if(!Android) fails-if(Android) == 1133905-6-v-rtl.html 1133905-ref-v-rtl.html
 skip-if(!Android) == 1133905-1-h-rtl.html 1133905-ref-h-rtl.html
 skip-if(!Android) == 1133905-2-h-rtl.html 1133905-ref-h-rtl.html
 skip-if(!Android) == 1133905-3-h-rtl.html 1133905-ref-h-rtl.html
 skip-if(!Android) == 1133905-4-h-rtl.html 1133905-ref-h-rtl.html
-skip-if(!Android) == 1133905-5-h-rtl.html 1133905-ref-h-rtl.html
-skip-if(!Android) == 1133905-6-h-rtl.html 1133905-ref-h-rtl.html
-skip-if(!Android) fails-if(Android) == 1133905-1-vh-rtl.html 1133905-ref-vh-rtl.html
-skip-if(!Android) fails-if(Android) == 1133905-2-vh-rtl.html 1133905-ref-vh-rtl.html
-skip-if(!Android) fails-if(Android) == 1133905-3-vh-rtl.html 1133905-ref-vh-rtl.html
+skip-if(!Android) fails-if(Android) == 1133905-5-h-rtl.html 1133905-ref-h-rtl.html
+skip-if(!Android) fails-if(Android) == 1133905-6-h-rtl.html 1133905-ref-h-rtl.html
+skip-if(!Android) == 1133905-1-vh-rtl.html 1133905-ref-vh-rtl.html
+skip-if(!Android) == 1133905-2-vh-rtl.html 1133905-ref-vh-rtl.html
+skip-if(!Android) == 1133905-3-vh-rtl.html 1133905-ref-vh-rtl.html
 skip-if(!Android) == 1133905-4-vh-rtl.html 1133905-ref-vh-rtl.html
 skip-if(!Android) fails-if(Android) == 1133905-5-vh-rtl.html 1133905-ref-vh-rtl.html
 skip-if(!Android) fails-if(Android) == 1133905-6-vh-rtl.html 1133905-ref-vh-rtl.html
 == 1149304-1-transform-change.html 1149304-1-transform-change-ref.html
 == 1150021-1.xul 1150021-1-ref.xul
 == 1151145-1.html 1151145-1-ref.html
 == 1151306-1.html 1151306-1-ref.html
 == 1153845-1.html 1153845-1-ref.html
@@ -1988,17 +1988,18 @@ fuzzy-if(skiaContent,0-1,0-1) == 1202512
 == 1219985-8.html 1219985-ref-opaque-clear.html
 == 1222226-1.html 1222226-1-ref.html
 pref(layout.css.overflow-clip-box.enabled,true) == 1226278.html 1226278-ref.html
 == 1230466.html about:blank
 random-if(gtkWidget) != 1238243-1.html 1238243-1-notref.html # may fail on Linux, depending on Korean fonts available
 == 1238243-2.html 1238243-2-ref.html
 fuzzy(0-100,0-2000) == 1239564.html 1239564-ref.html
 == 1242172-1.html 1242172-1-ref.html
-fuzzy-if(webrender,0-2,0-2601) == 1242172-2.html 1242172-2-ref.html
+# Bug 1520320 is tracking this Android failure case.
+fuzzy-if(webrender,0-2,0-2601) fails-if(Android) == 1242172-2.html 1242172-2-ref.html
 == 1242781.html 1242781-ref.html
 == 1263845.html 1263845-ref.html
 == 1260543-1.html 1260543-1-ref.html
 == 1271714-1.html 1271714-1-ref.html
 == 1272997-1.html 1272997-1-ref.html
 random-if(!winWidget) == 1273154-1.html 1273154-1-ref.html # depends on Windows font
 random-if(!winWidget) == 1273154-2.html 1273154-2-ref.html # depends on Windows font
 == 1274368-1.html 1274368-1-ref.html
--- a/layout/reftests/transform/compound-1-ref.html
+++ b/layout/reftests/transform/compound-1-ref.html
@@ -1,10 +1,11 @@
 <html>
 <head>
+  <meta name="viewport" content="initial-scale=1">
   <style type="text/css">
     div.test
     {
     background-color: gold;
     width:200px;
     height:100px;
     border: 1px solid black;
     }
--- a/layout/reftests/transform/compound-1a.html
+++ b/layout/reftests/transform/compound-1a.html
@@ -1,10 +1,11 @@
 <html>
 <head>
+  <meta name="viewport" content="initial-scale=1">
   <style type="text/css">
     div.test
     {
     background-color: gold;
     width:200px;
     height:100px;
     border: 1px solid black;
     }
--- a/layout/reftests/transform/reftest.list
+++ b/layout/reftests/transform/reftest.list
@@ -1,14 +1,14 @@
 # Transforms specifying singular matrices shouldn't display at all.
 # NOTE: Regressions might manifest themselves as reftest timeouts on
 # this test.
 == singular-1a.html about:blank
 # Multiple transforms should act identically to nested divs.
-fuzzy-if(webrender,0-1,0-27) == compound-1a.html compound-1-ref.html
+fuzzy-if(webrender,0-1,0-27) pref(apz.allow_zooming,true) == compound-1a.html compound-1-ref.html
 != compound-1a.html compound-1-fail.html
 == dynamic-inherit-1.html dynamic-inherit-1-ref.html
 == dynamic-addremove-1a.html dynamic-addremove-1-ref.html
 == dynamic-addremove-1b.html dynamic-addremove-1-ref.html
 == dynamic-addremove-1c.html dynamic-addremove-1-ref.html
 == dynamic-addremove-2.html dynamic-addremove-2-ref.html
 # translatex should act like position: relative
 == translatex-1a.html translatex-1-ref.html