Bug 1342992: Make mscom::Weakref final; r=jimm
authorAaron Klotz <aklotz@mozilla.com>
Mon, 27 Feb 2017 11:44:45 -0700
changeset 394158 d34e52a93da46aaf20887bafd7c72ebd36bad2b9
parent 394157 ce4d5be6f3fb01e6f896d7be1ee5a027289b28a4
child 394159 55f798bd9db4fc62d13cade1c384f960166b109d
push id1468
push userasasaki@mozilla.com
push dateMon, 05 Jun 2017 19:31:07 +0000
treeherdermozilla-release@0641fc6ee9d1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjimm
bugs1342992
milestone54.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1342992: Make mscom::Weakref final; r=jimm MozReview-Commit-ID: 7SZpXP2adK7
ipc/mscom/WeakRef.h
--- a/ipc/mscom/WeakRef.h
+++ b/ipc/mscom/WeakRef.h
@@ -100,30 +100,32 @@ protected:
 
 private:
   RefPtr<detail::SharedRef> mSharedRef;
   ULONG                     mRefCnt;
   Flags                     mFlags;
   CRITICAL_SECTION          mCSForQI;
 };
 
-class WeakRef : public IWeakReference
+class WeakRef final : public IWeakReference
 {
 public:
   // IUnknown
   STDMETHODIMP QueryInterface(REFIID riid, void** ppv) override;
   STDMETHODIMP_(ULONG) AddRef() override;
   STDMETHODIMP_(ULONG) Release() override;
 
   // IWeakReference
   STDMETHODIMP Resolve(REFIID aIid, void** aOutStrongReference) override;
 
   explicit WeakRef(RefPtr<detail::SharedRef>& aSharedRef);
 
 private:
+  ~WeakRef() = default;
+
   Atomic<ULONG>             mRefCnt;
   RefPtr<detail::SharedRef> mSharedRef;
 };
 
 } // namespace mscom
 } // namespace mozilla
 
 #endif // mozilla_mscom_WeakRef_h