Bug 1160267 - JS build files should not declare IMPL_MFBT. r=glandium
authorEric Rahm <erahm@mozilla.com>
Thu, 30 Apr 2015 15:10:03 -0700
changeset 273459 d2736b5af22677cd0a21f8d3449f7c5851859621
parent 273458 2db8c3341c29a9afc823445b34cbe9a68579211c
child 273460 bfcba00a76c003102f57b2058aba631ddd1c0832
push id863
push userraliiev@mozilla.com
push dateMon, 03 Aug 2015 13:22:43 +0000
treeherdermozilla-release@f6321b14228d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersglandium
bugs1160267
milestone40.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1160267 - JS build files should not declare IMPL_MFBT. r=glandium
js/src/gdb/moz.build
js/src/jsapi-tests/moz.build
js/src/shell/moz.build
--- a/js/src/gdb/moz.build
+++ b/js/src/gdb/moz.build
@@ -15,20 +15,17 @@ UNIFIED_SOURCES += [
     'tests/test-JSString.cpp',
     'tests/test-JSSymbol.cpp',
     'tests/test-jsval.cpp',
     'tests/test-prettyprinters.cpp',
     'tests/test-Root.cpp',
     'tests/typedef-printers.cpp',
 ]
 
-# Building against js_static requires that we declare mfbt sybols "exported"
-# on its behalf.
-for var in ('EXPORT_JS_API', 'IMPL_MFBT'):
-    DEFINES[var] = True
+DEFINES['EXPORT_JS_API'] = True
 
 LOCAL_INCLUDES += ['..']
 GENERATED_INCLUDES += ['..']
 
 USE_LIBS += [
     'static:js',
 ]
 
--- a/js/src/jsapi-tests/moz.build
+++ b/js/src/jsapi-tests/moz.build
@@ -95,19 +95,16 @@ if CONFIG['ENABLE_ION']:
         'testJitMoveEmitterCycles-mips.cpp',
         'testJitMoveEmitterCycles.cpp',
         'testJitRangeAnalysis.cpp',
         'testJitRegisterSet.cpp',
         'testJitRValueAlloc.cpp',
     ]
 
 DEFINES['EXPORT_JS_API'] = True
-# Building against js_static requires that we declare mfbt sybols "exported"
-# on its behalf.
-DEFINES['IMPL_MFBT'] = True
 
 LOCAL_INCLUDES += ['..']
 GENERATED_INCLUDES += ['..']
 
 USE_LIBS += [
     'static:js',
 ]
 
--- a/js/src/shell/moz.build
+++ b/js/src/shell/moz.build
@@ -11,20 +11,17 @@ if CONFIG['JS_SHELL_NAME']:
     USE_LIBS += ['static:js']
 
 UNIFIED_SOURCES += [
     'js.cpp',
     'jsoptparse.cpp',
     'OSObject.cpp'
 ]
 
-# Building against js_static requires that we declare mfbt sybols "exported"
-# on its behalf.
-for var in ('EXPORT_JS_API', 'IMPL_MFBT'):
-    DEFINES[var] = True
+DEFINES['EXPORT_JS_API'] = True
 
 if CONFIG['_MSC_VER']:
     # unnecessary PGO for js shell.  But gcc cannot turn off pgo because it is
     # necessary to link PGO lib on gcc when a object/static lib are compiled
     # for PGO.
     NO_PGO = True
 
 LOCAL_INCLUDES += ['..']