Bug 1442972 - DOMSVGPoint constructor checks that mX is finite twice and mY finite not at all r=dholbert
authorRobert Longson <longsonr@gmail.com>
Fri, 09 Mar 2018 04:29:52 +0000
changeset 462334 d2474e66469725bef72fc67c20eb99282018caad
parent 462333 d9297cea0239855bcbef78e40967b4054983a093
child 462335 1eb7354064c1a27d53d97929db2c6a1d762f4998
push id1683
push usersfraser@mozilla.com
push dateThu, 26 Apr 2018 16:43:40 +0000
treeherdermozilla-release@5af6cb21869d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdholbert
bugs1442972
milestone60.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1442972 - DOMSVGPoint constructor checks that mX is finite twice and mY finite not at all r=dholbert
dom/svg/DOMSVGPoint.h
--- a/dom/svg/DOMSVGPoint.h
+++ b/dom/svg/DOMSVGPoint.h
@@ -77,17 +77,17 @@ public:
     mPt.mY = aY;
   }
 
   explicit DOMSVGPoint(const Point& aPt)
     : nsISVGPoint()
   {
     mPt.mX = aPt.x;
     mPt.mY = aPt.y;
-    NS_ASSERTION(IsFinite(mPt.mX) && IsFinite(mPt.mX),
+    NS_ASSERTION(IsFinite(mPt.mX) && IsFinite(mPt.mY),
                  "DOMSVGPoint coords are not finite");
   }
 
 
   // WebIDL
   virtual float X() override;
   virtual void SetX(float aX, ErrorResult& rv) override;
   virtual float Y() override;