Bug 929783 - Fix an exact rooting hazard in InterAppComm::EnabledForScope; r=smaug
authorTerrence Cole <terrence@mozilla.com>
Tue, 22 Oct 2013 11:35:24 -0700
changeset 166513 d0e2322cbc600214f76d82d62620fc0a72b8982c
parent 166512 8b72c1a37bd614c36ea0471efacf88c0022e9b4f
child 166514 6155ea7e8dea89a8efd1660d939433e164dd3294
push id428
push userbbajaj@mozilla.com
push dateTue, 28 Jan 2014 00:16:25 +0000
treeherdermozilla-release@cd72a7ff3a75 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssmaug
bugs929783
milestone27.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 929783 - Fix an exact rooting hazard in InterAppComm::EnabledForScope; r=smaug
dom/apps/src/InterAppComm.cpp
dom/apps/src/InterAppComm.h
--- a/dom/apps/src/InterAppComm.cpp
+++ b/dom/apps/src/InterAppComm.cpp
@@ -7,17 +7,17 @@
 #include "nsPIDOMWindow.h"
 #include "nsJSPrincipals.h"
 #include "mozilla/Preferences.h"
 #include "AccessCheck.h"
 
 using namespace mozilla::dom;
 
 /* static */ bool
-InterAppComm::EnabledForScope(JSContext* /* unused */, JSObject* aObj)
+InterAppComm::EnabledForScope(JSContext* /* unused */, JS::Handle<JSObject*> aObj)
 {
   // Disable the constructors if they're disabled by the preference for sure.
   if (!Preferences::GetBool("dom.inter-app-communication-api.enabled", false)) {
   	return false;
   }
 
   // Only expose the constructors to the chrome codes for Gecko internal uses.
   // The content pages shouldn't be aware of the constructors.
--- a/dom/apps/src/InterAppComm.h
+++ b/dom/apps/src/InterAppComm.h
@@ -12,15 +12,15 @@ struct JSContext;
 class JSObject;
 
 namespace mozilla {
 namespace dom {
 
 class InterAppComm
 {
 public:
-  static bool EnabledForScope(JSContext* /* unused */, JSObject* aObj);
+  static bool EnabledForScope(JSContext* /* unused */, JS::Handle<JSObject*> aObj);
 };
 
 } // namespace dom
 } // namespace mozilla
 
 #endif // mozilla_dom_apps_InterAppComm_h