Bug 1150515: Set the subsystem to WINDOWS,5.02 for wow_helper so that it runs on WinXP 64-bit. r=glandium
authorBob Owen <bobowencode@gmail.com>
Thu, 30 Apr 2015 09:48:03 +0100
changeset 273141 d0703ff693a12ed91438ee9664cc7a490c12df65
parent 273140 69cff2238ff98ccac986c9f7c15746448d2aa0b4
child 273142 7792f4778da8d68d445252f78ce5bf719f6f5476
push id863
push userraliiev@mozilla.com
push dateMon, 03 Aug 2015 13:22:43 +0000
treeherdermozilla-release@f6321b14228d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersglandium
bugs1150515
milestone40.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1150515: Set the subsystem to WINDOWS,5.02 for wow_helper so that it runs on WinXP 64-bit. r=glandium
security/sandbox/win/wow_helper/Makefile.in
--- a/security/sandbox/win/wow_helper/Makefile.in
+++ b/security/sandbox/win/wow_helper/Makefile.in
@@ -35,8 +35,13 @@ LIB = $(call lazy,LIB,$$(shell python -c
 CXXFLAGS := $(filter-out -arch:IA32,$(CXXFLAGS))
 
 # OS_COMPILE_CXXFLAGS includes mozilla-config.h, which contains x86-specific
 # defines breaking the build.
 OS_COMPILE_CXXFLAGS :=
 
 # LNK1246: '/SAFESEH' not compatible with 'x64' target machine
 LDFLAGS := $(filter-out -SAFESEH,$(LDFLAGS))
+
+# When targetting x64, we need to specify a subsystem of at least 5.02, because
+# the 5.01 value we inherit from the x86 parts is silently ignored, making the
+# linker default to 6.00 (Vista) as of VS2013.
+WIN32_GUI_EXE_LDFLAGS=-SUBSYSTEM:WINDOWS,5.02