Bug 1245978 part 2: Drop redundant 'virtual' keyword from NS_DECL_NSIDOCUMENTVIEWERPRINT macro (which already includes 'override' keyword). r=heycam
authorDaniel Holbert <dholbert@cs.stanford.edu>
Mon, 29 Feb 2016 15:09:13 -0800
changeset 324416 ceea6cf9be9d9fd850e0dab7ef78e30922e7dfb3
parent 324415 b2b51d8c60cfefbf29bdac04d4e7119d3f36d819
child 324417 c8e1ff0ab5a4cc172155cefbdd47a7b8fea66b64
push id1128
push userjlund@mozilla.com
push dateWed, 01 Jun 2016 01:31:59 +0000
treeherdermozilla-release@fe0d30de989d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersheycam
bugs1245978
milestone47.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1245978 part 2: Drop redundant 'virtual' keyword from NS_DECL_NSIDOCUMENTVIEWERPRINT macro (which already includes 'override' keyword). r=heycam This makes these lines shorter, and brings us into alignment with the Mozilla Coding Style Guide. See mozilla.dev.platform post "Proposal to alter the coding style to not require the usage of 'virtual' where 'override' is used" for more info.
layout/base/nsIDocumentViewerPrint.h
--- a/layout/base/nsIDocumentViewerPrint.h
+++ b/layout/base/nsIDocumentViewerPrint.h
@@ -64,23 +64,23 @@ public:
                                            nsIPresShell* aPresShell) = 0;
 };
 
 NS_DEFINE_STATIC_IID_ACCESSOR(nsIDocumentViewerPrint,
                               NS_IDOCUMENT_VIEWER_PRINT_IID)
 
 /* Use this macro when declaring classes that implement this interface. */
 #define NS_DECL_NSIDOCUMENTVIEWERPRINT \
-  virtual void     SetIsPrinting(bool aIsPrinting) override; \
-  virtual bool     GetIsPrinting() override; \
-  virtual void     SetIsPrintPreview(bool aIsPrintPreview) override; \
-  virtual bool     GetIsPrintPreview() override; \
-  virtual mozilla::StyleSetHandle CreateStyleSet(nsIDocument* aDocument) override; \
-  virtual void     IncrementDestroyRefCount() override; \
-  virtual void     ReturnToGalleyPresentation() override; \
-  virtual void     OnDonePrinting() override; \
-  virtual bool     IsInitializedForPrintPreview() override; \
-  virtual void     InitializeForPrintPreview() override; \
-  virtual void     SetPrintPreviewPresentation(nsViewManager* aViewManager, \
-                                               nsPresContext* aPresContext, \
-                                               nsIPresShell* aPresShell) override;
+  void     SetIsPrinting(bool aIsPrinting) override; \
+  bool     GetIsPrinting() override; \
+  void     SetIsPrintPreview(bool aIsPrintPreview) override; \
+  bool     GetIsPrintPreview() override; \
+  mozilla::StyleSetHandle CreateStyleSet(nsIDocument* aDocument) override; \
+  void     IncrementDestroyRefCount() override; \
+  void     ReturnToGalleyPresentation() override; \
+  void     OnDonePrinting() override; \
+  bool     IsInitializedForPrintPreview() override; \
+  void     InitializeForPrintPreview() override; \
+  void     SetPrintPreviewPresentation(nsViewManager* aViewManager, \
+                                       nsPresContext* aPresContext, \
+                                       nsIPresShell* aPresShell) override;
 
 #endif /* nsIDocumentViewerPrint_h___ */