Bug 1270059: ESLint fix r=bustage
authorRandell Jesup <rjesup@jesup.org>
Sat, 26 Jan 2019 12:43:17 -0500
changeset 515569 cec0a3a47cdb2caf8c5a51a3718b7a6f233858c2
parent 515568 eec1a6963a9cc61b02611259233f54fd15094792
child 515579 2d2647957a09b9f573042b9b360c7add381b9e3d
push id1953
push userffxbld-merge
push dateMon, 11 Mar 2019 12:10:20 +0000
treeherdermozilla-release@9c35dcbaa899 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbustage
bugs1270059
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1270059: ESLint fix r=bustage on a CLOSED TREE
testing/talos/talos/pageloader/chrome/lh_hero.js
--- a/testing/talos/talos/pageloader/chrome/lh_hero.js
+++ b/testing/talos/talos/pageloader/chrome/lh_hero.js
@@ -18,25 +18,22 @@ function _contentHeroHandler(isload) {
     // we want the element 100% visible on the viewport
     var options = {root: null, rootMargin: "0px", threshold: [1]};
     try {
       obs = new content.window.IntersectionObserver(callback, options);
       obs.observe(el);
     } catch (err) {
       sendAsyncMessage("PageLoader:Error", {"msg": err.message});
     }
-  } else {
+  } else if (isload) {
     // If the hero element is added from a settimeout handler, it might not run before 'load'
-    dumpLine("no hero, isload = " + isload);
-    if (isload) {
-      setTimeout(function() {_contentHeroHandler(false); }, 5000);
-    } else {
-      var err = "Could not find a tag with an elmenttiming attr on the page";
-      sendAsyncMessage("PageLoader:Error", {"msg": err});
-    }
+    setTimeout(function() { _contentHeroHandler(false); }, 5000);
+  } else {
+    var err = "Could not find a tag with an elmenttiming attr on the page";
+    sendAsyncMessage("PageLoader:Error", {"msg": err});
   }
   return obs;
 }
 
 function _contentHeroLoadHandler() {
   _contentHeroHandler(true);
 }