Backed out changeset ee28acf1382f (bug 1521170) for X2 / TV failures CLOSED TREE
authorshindli <shindli@mozilla.com>
Wed, 23 Jan 2019 02:28:22 +0200
changeset 514934 ce496fde2eddf168291d48576e7ef3a06e75896a
parent 514929 714ae096d76ebff59c487965500410568ac91008
child 514935 02b9e71499119748b7a4ea5572fbf1c9a41dcb9b
push id1953
push userffxbld-merge
push dateMon, 11 Mar 2019 12:10:20 +0000
treeherdermozilla-release@9c35dcbaa899 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1521170
milestone66.0a1
backs outee28acf1382f6df640735c8d1cb66c3c80367153
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset ee28acf1382f (bug 1521170) for X2 / TV failures CLOSED TREE
tools/lint/eslint/eslint-plugin-mozilla/tests/use-returnValue.js
--- a/tools/lint/eslint/eslint-plugin-mozilla/tests/use-returnValue.js
+++ b/tools/lint/eslint/eslint-plugin-mozilla/tests/use-returnValue.js
@@ -13,26 +13,27 @@ var RuleTester = require("eslint/lib/tes
 const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 6 } });
 
 // ------------------------------------------------------------------------------
 // Tests
 // ------------------------------------------------------------------------------
 
 function invalidCode(code, methodName) {
   let message = `{Array/String}.${methodName} doesn't modify the instance in-place`;
-  return {code, errors: [{message, type: "ExpressionStatement"}]};
+  return {code, errors: [{message, type: "MemberExpression"}]};
 }
 
 ruleTester.run("use-returnValue", rule, {
   valid: [
     "a = foo.concat(bar)",
     "b = bar.concat([1,3,4])",
     "c = baz.concat()",
     "d = qux.join(' ')",
     "e = quux.slice(1)",
+    "Int64.join(-0x80000001, 0)",
   ],
   invalid: [
     invalidCode("foo.concat(bar)", "concat"),
     invalidCode("bar.concat([1,3,4])", "concat"),
     invalidCode("baz.concat()", "concat"),
     invalidCode("qux.join(' ')", "join"),
     invalidCode("quux.slice(1)", "slice"),
   ],