Bug 1398893 - Breakpoints cannot be removed. r=jdescottes, a=lizzard
authorjason laster <jlaster@mozilla.com>
Mon, 11 Sep 2017 16:29:31 -0400
changeset 424061 cdfda62c6effbb46b3b1bcd2f92dccf642881647
parent 424060 ee35e197066d9c09218bd26f4d0ec72faa9fac6a
child 424062 aa3740564226ff05000c83f7b07a919334bd7ac1
push id1517
push userjlorenzo@mozilla.com
push dateThu, 14 Sep 2017 16:50:54 +0000
treeherdermozilla-release@3b41fd564418 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjdescottes, lizzard
bugs1398893
milestone56.0
Bug 1398893 - Breakpoints cannot be removed. r=jdescottes, a=lizzard
devtools/client/debugger/new/debugger.js
--- a/devtools/client/debugger/new/debugger.js
+++ b/devtools/client/debugger/new/debugger.js
@@ -2743,17 +2743,17 @@ return /******/ (function(modules) { // 
 
 	module.exports = isIndex;
 
 
 /***/ },
 /* 118 */
 /***/ function(module, exports) {
 
-	
+
 
 /***/ },
 /* 119 */
 /***/ function(module, exports, __webpack_require__) {
 
 	/* WEBPACK VAR INJECTION */(function(process) {// Copyright Joyent, Inc. and other Node contributors.
 	//
 	// Permission is hereby granted, free of charge, to any person obtaining a
@@ -4579,17 +4579,17 @@ return /******/ (function(modules) { // 
 	      }
 	      return ii;
 	    };
 
 	    ArraySeq.prototype.__iterator = function(type, reverse) {
 	      var array = this._array;
 	      var maxIndex = array.length - 1;
 	      var ii = 0;
-	      return new Iterator(function() 
+	      return new Iterator(function()
 	        {return ii > maxIndex ?
 	          iteratorDone() :
 	          iteratorValue(type, ii, array[reverse ? maxIndex - ii++ : ii++])}
 	      );
 	    };
 
 
 
@@ -5050,17 +5050,17 @@ return /******/ (function(modules) { // 
 	          return ii + 1;
 	        }
 	      }
 	      return ii;
 	    };
 
 	    Repeat.prototype.__iterator = function(type, reverse) {var this$0 = this;
 	      var ii = 0;
-	      return new Iterator(function() 
+	      return new Iterator(function()
 	        {return ii < this$0.size ? iteratorValue(type, ii++, this$0._value) : iteratorDone()}
 	      );
 	    };
 
 	    Repeat.prototype.equals = function(other) {
 	      return other instanceof Repeat ?
 	        is(this._value, other._value) :
 	        deepEqual(other);
@@ -7248,17 +7248,17 @@ return /******/ (function(modules) { // 
 	    reversedSequence.reverse = function()  {return iterable};
 	    if (iterable.flip) {
 	      reversedSequence.flip = function () {
 	        var flipSequence = flipFactory(iterable);
 	        flipSequence.reverse = function()  {return iterable.flip()};
 	        return flipSequence;
 	      };
 	    }
-	    reversedSequence.get = function(key, notSetValue) 
+	    reversedSequence.get = function(key, notSetValue)
 	      {return iterable.get(useKeys ? key : -1 - key, notSetValue)};
 	    reversedSequence.has = function(key )
 	      {return iterable.has(useKeys ? key : -1 - key)};
 	    reversedSequence.includes = function(value ) {return iterable.includes(value)};
 	    reversedSequence.cacheResult = cacheResultThrough;
 	    reversedSequence.__iterate = function (fn, reverse) {var this$0 = this;
 	      return iterable.__iterate(function(v, k)  {return fn(v, k, this$0)}, !reverse);
 	    };
@@ -7447,17 +7447,17 @@ return /******/ (function(modules) { // 
 
 	  function takeWhileFactory(iterable, predicate, context) {
 	    var takeSequence = makeSequence(iterable);
 	    takeSequence.__iterateUncached = function(fn, reverse) {var this$0 = this;
 	      if (reverse) {
 	        return this.cacheResult().__iterate(fn, reverse);
 	      }
 	      var iterations = 0;
-	      iterable.__iterate(function(v, k, c) 
+	      iterable.__iterate(function(v, k, c)
 	        {return predicate.call(context, v, k, c) && ++iterations && fn(v, k, this$0)}
 	      );
 	      return iterations;
 	    };
 	    takeSequence.__iteratorUncached = function(type, reverse) {var this$0 = this;
 	      if (reverse) {
 	        return this.cacheResult().__iterator(type, reverse);
 	      }
@@ -7638,17 +7638,17 @@ return /******/ (function(modules) { // 
 	  }
 
 
 	  function interposeFactory(iterable, separator) {
 	    var interposedSequence = makeSequence(iterable);
 	    interposedSequence.size = iterable.size && iterable.size * 2 -1;
 	    interposedSequence.__iterateUncached = function(fn, reverse) {var this$0 = this;
 	      var iterations = 0;
-	      iterable.__iterate(function(v, k) 
+	      iterable.__iterate(function(v, k)
 	        {return (!iterations || fn(separator, iterations++, this$0) !== false) &&
 	        fn(v, iterations++, this$0) !== false},
 	        reverse
 	      );
 	      return iterations;
 	    };
 	    interposedSequence.__iteratorUncached = function(type, reverse) {
 	      var iterator = iterable.__iterator(ITERATE_VALUES, reverse);
@@ -14529,16 +14529,17 @@ return /******/ (function(modules) { // 
 
 	  var locationId = (0, _breakpoint2.makeLocationId)(breakpoint.location);
 	  return state.setIn(["breakpoints", locationId], breakpoint);
 	}
 
 	function removeBreakpoint(state, action) {
 	  var breakpoint = action.breakpoint;
 
+
 	  var id = (0, _breakpoint2.makeLocationId)(breakpoint.location);
 	  return state.deleteIn(["breakpoints", id]);
 	}
 
 	// Selectors
 	// TODO: these functions should be moved out of the reducer
 
 	function getBreakpoints(state) {
@@ -32705,17 +32706,17 @@ return /******/ (function(modules) { // 
 	}
 
 	module.exports = networkRequest;
 
 /***/ },
 /* 902 */
 /***/ function(module, exports) {
 
-	
+
 
 	function WorkerDispatcher() {
 	  this.msgId = 1;
 	  this.worker = null;
 	} /* This Source Code Form is subject to the terms of the Mozilla Public
 	   * License, v. 2.0. If a copy of the MPL was not distributed with this
 	   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
@@ -36805,17 +36806,17 @@ return /******/ (function(modules) { // 
 	module.exports = isEmpty;
 
 
 /***/ },
 /* 964 */,
 /* 965 */
 /***/ function(module, exports) {
 
-	
+
 	/**
 	 * slice() reference.
 	 */
 
 	var slice = Array.prototype.slice;
 
 	/**
 	 * Expose `co`.
@@ -49823,16 +49824,21 @@ return /******/ (function(modules) { // 
 	  return state.setIn(["pendingBreakpoints", locationId], pendingBreakpoint);
 	}
 
 	function removeBreakpoint(state, action) {
 	  var breakpoint = action.breakpoint;
 
 	  var locationId = (0, _breakpoint.makePendingLocationId)(breakpoint.location);
 
+	  const pendingBp = state.getIn(["pendingBreakpoints", locationId]);
+	  if (!pendingBp) {
+		return state.set("pendingBreakpoints", I.Map());
+	  }
+
 	  return state.deleteIn(["pendingBreakpoints", locationId]);
 	}
 
 	// Selectors
 	// TODO: these functions should be moved out of the reducer
 
 	function getPendingBreakpoints(state) {
 	  return state.pendingBreakpoints.pendingBreakpoints;
@@ -52794,9 +52800,9 @@ return /******/ (function(modules) { // 
 /* 1174 */
 /***/ function(module, exports) {
 
 	module.exports = "<svg xmlns:dc=\"http://purl.org/dc/elements/1.1/\" xmlns:cc=\"http://creativecommons.org/ns#\" xmlns:rdf=\"http://www.w3.org/1999/02/22-rdf-syntax-ns#\" xmlns:svg=\"http://www.w3.org/2000/svg\" xmlns=\"http://www.w3.org/2000/svg\" viewBox=\"0 0 400 400\" xml:space=\"preserve\" id=\"svg2\" version=\"1.1\"><metadata id=\"metadata8\"><rdf:RDF><cc:Work rdf:about><dc:format>image/svg+xml</dc:format><dc:type rdf:resource=\"http://purl.org/dc/dcmitype/StillImage\"></dc></cc:Work></rdf:RDF></metadata><defs id=\"defs6\"></defs><g transform=\"matrix(1.3333333,0,0,-1.3333333,0,400)\" id=\"g10\"><g transform=\"translate(178.0626,235.0086)\" id=\"g12\"><path id=\"path14\" style=\"fill:#41b883;fill-opacity:1;fill-rule:nonzero;stroke:none\" d=\"M 0,0 -22.669,-39.264 -45.338,0 h -75.491 L -22.669,-170.017 75.491,0 Z\"></path></g><g transform=\"translate(178.0626,235.0086)\" id=\"g16\"><path id=\"path18\" style=\"fill:#34495e;fill-opacity:1;fill-rule:nonzero;stroke:none\" d=\"M 0,0 -22.669,-39.264 -45.338,0 H -81.565 L -22.669,-102.01 36.227,0 Z\"></path></g></g></svg>"
 
 /***/ }
 /******/ ])
 });
-;
\ No newline at end of file
+;