Bug 1636511 - Disable the OS auth feature in about:logins on Release and Beta. r=MattN a=RyanVM
authorJared Wein <jwein@mozilla.com>
Tue, 12 May 2020 02:00:19 +0000
changeset 589278 cdf352f02ac4e034be96d14031fd6cc37dbe9ab9
parent 589277 ede65b41d36dde3f517abd974c4ed2d6b4767b50
child 589279 f43c54cee722673de8b46d9af515a24478508c5b
push id2332
push userryanvm@gmail.com
push dateThu, 14 May 2020 14:18:23 +0000
treeherdermozilla-release@cdf352f02ac4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersMattN, RyanVM
bugs1636511
milestone76.0.2
Bug 1636511 - Disable the OS auth feature in about:logins on Release and Beta. r=MattN a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D74676
browser/app/profile/firefox.js
browser/components/aboutlogins/tests/browser/browser.ini
browser/components/preferences/in-content/tests/browser.ini
--- a/browser/app/profile/firefox.js
+++ b/browser/app/profile/firefox.js
@@ -1720,17 +1720,17 @@ pref("dom.mozBrowserFramesEnabled", true
 pref("extensions.pocket.api", "api.getpocket.com");
 pref("extensions.pocket.enabled", true);
 pref("extensions.pocket.oAuthConsumerKey", "40249-e88c401e1b1f2242d9e441c4");
 pref("extensions.pocket.site", "getpocket.com");
 
 // Can be removed once Bug 1618058 is resolved.
 pref("signon.generation.confidenceThreshold", "0.75");
 
-pref("signon.management.page.os-auth.enabled", true);
+pref("signon.management.page.os-auth.enabled", false);
 pref("signon.management.page.breach-alerts.enabled", true);
 pref("signon.management.page.vulnerable-passwords.enabled", true);
 pref("signon.management.page.sort", "name");
 pref("signon.management.overrideURI", "about:logins?filter=%DOMAIN%");
 // The utm_creative value is appended within the code (specific to the location on
 // where it is clicked). Be sure that if these two prefs are updated, that
 // the utm_creative param be last.
 pref("signon.management.page.mobileAndroidURL", "https://app.adjust.com/6tteyjo?redirect=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dmozilla.lockbox&utm_campaign=Desktop&utm_adgroup=InProduct&utm_creative=");
--- a/browser/components/aboutlogins/tests/browser/browser.ini
+++ b/browser/components/aboutlogins/tests/browser/browser.ini
@@ -1,13 +1,14 @@
 [DEFAULT]
 support-files =
   head.js
 prefs =
   signon.management.page.vulnerable-passwords.enabled=true
+  signon.management.page.os-auth.enabled=true
 
 # Run first so content events from previous tests won't trickle in.
 # Skip ASAN and debug since waiting for content events is already slow.
 [browser_aaa_eventTelemetry_run_first.js]
 skip-if = asan || ccov || debug # bug 1605494 is more prevalent on linux
 [browser_alertDismissedAfterChangingPassword.js]
 [browser_breachAlertShowingForAddedLogin.js]
 [browser_confirmDeleteDialog.js]
--- a/browser/components/preferences/in-content/tests/browser.ini
+++ b/browser/components/preferences/in-content/tests/browser.ini
@@ -1,12 +1,13 @@
 [DEFAULT]
 prefs =
   extensions.formautofill.available='on'
   extensions.formautofill.creditCards.available=true
+  signon.management.page.os-auth.enabled=true
 support-files =
   head.js
   privacypane_tests_perwindow.js
   addons/pl-dictionary.xpi
   addons/set_homepage.xpi
   addons/set_newtab.xpi
 
 [browser_applications_selection.js]