Backed out 3 changesets (bug 1414401) for failing Linux opt /webdriver/tests/actions/key_shortcuts.py r=backout on a CLOSED TREE
authorbtara <btara@mozilla.com>
Sun, 12 Nov 2017 12:39:37 +0200
changeset 444697 cdcac626d2bad3fefa894517c9d6f80982f79eb1
parent 444696 8d17c033d79b2a1669f150ed2044f6bd5bebb2d6
child 444710 b0ae922973c1294a875dee38c6a0295957adee8b
push id1618
push userCallek@gmail.com
push dateThu, 11 Jan 2018 17:45:48 +0000
treeherdermozilla-release@882ca853e05a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbackout
bugs1414401
milestone58.0a1
backs out8d17c033d79b2a1669f150ed2044f6bd5bebb2d6
b445d7d2eadc623b5045d8e166dd3533c5649ff8
cb2f1791b209d02f3a05282745ae5a84778eb0a7
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out 3 changesets (bug 1414401) for failing Linux opt /webdriver/tests/actions/key_shortcuts.py r=backout on a CLOSED TREE Backed out changeset 8d17c033d79b (bug 1414401) Backed out changeset b445d7d2eadc (bug 1414401) Backed out changeset cb2f1791b209 (bug 1414401)
taskcluster/ci/test/test-sets.yml
testing/web-platform/tests/webdriver/tests/actions/key_shortcuts.py
toolkit/moz.configure
--- a/taskcluster/ci/test/test-sets.yml
+++ b/taskcluster/ci/test/test-sets.yml
@@ -295,17 +295,16 @@ linux32-tests:
     - mochitest-clipboard
     - mochitest-gpu
     - mochitest-media
     - mochitest-webgl
     - reftest
     - reftest-no-accel
     - web-platform-tests
     - web-platform-tests-reftests
-    - web-platform-tests-wdspec
     - xpcshell
 
 linux32-opt-tests:
     # mochitest-dt is too slow on linux32/debug
     - mochitest-devtools-chrome
 
 desktop-screenshot-capture:
     - browser-screenshots
--- a/testing/web-platform/tests/webdriver/tests/actions/key_shortcuts.py
+++ b/testing/web-platform/tests/webdriver/tests/actions/key_shortcuts.py
@@ -1,10 +1,8 @@
-# META: timeout=long
-
 from tests.actions.support.keys import Keys, MODIFIER_KEY
 from tests.actions.support.refine import get_keys
 
 
 def test_mod_a_and_backspace_deletes_all_text(session, key_reporter, key_chain):
     key_chain.send_keys("abc d") \
              .key_down(MODIFIER_KEY) \
              .key_down("a") \
@@ -42,8 +40,10 @@ def test_mod_a_mod_x_deletes_all_text(se
              .key_up(MODIFIER_KEY) \
              .key_up("a") \
              .key_down(MODIFIER_KEY) \
              .key_down("x") \
              .key_up(MODIFIER_KEY) \
              .key_up("x") \
              .perform()
     assert get_keys(key_reporter) == ""
+
+
--- a/toolkit/moz.configure
+++ b/toolkit/moz.configure
@@ -1109,18 +1109,19 @@ set_config('ENABLE_MARIONETTE', marionet
 # geckodriver WebDriver implementation
 # ==============================================================
 option('--enable-geckodriver', help='Enable WebDriver implementation')
 
 @depends('--enable-geckodriver',
          'MOZ_AUTOMATION',
          compile_environment,
          cross_compiling,
-         hazard_analysis)
-def geckodriver(enable, automation, compile_env, cross_compile, hazard):
+         hazard_analysis,
+         target)
+def geckodriver(enable, automation, compile_env, cross_compile, hazard, target):
     """
     geckodriver is implied on supported platforms when MOZ_AUTOMATION
     is set, but we also provide the --enable-geckodriver option for
     developers to use.
 
     At the present time, we want individual developers to be able to
     opt-in to building geckodriver locally, and for it to be enabled by
     default on supported CI build platforms.
@@ -1128,17 +1129,18 @@ def geckodriver(enable, automation, comp
     if enable:
         if not compile_env:
             die("--enable-geckodriver is not available without a compile "
                 "environment. A geckodriver binary will be downloaded during "
                 "an artifact build by default where available.")
         return True
 
     if enable.origin == 'default':
-        broken_platforms = cross_compile or hazard
+        linux32 = target.kernel == 'Linux' and target.cpu == 'x86'
+        broken_platforms = cross_compile or linux32 or hazard
 
         if automation and compile_env and not broken_platforms:
             return True
 
 set_config('ENABLE_GECKODRIVER', geckodriver)
 
 # WebRTC
 # ========================================================