Bug 1520282 - When launching android emulator from mach, use a new pipe to stdin; r=bc
authorGeoff Brown <gbrown@mozilla.com>
Wed, 23 Jan 2019 08:29:09 -0700
changeset 515127 cac13d592b66535ee7abbf05a71952f21654dc21
parent 515126 2d7c13dfec2dfc7f3300e767315db3518ab96676
child 515128 b421f21d545c5c7bae23fa1e0fadde581975c981
push id1953
push userffxbld-merge
push dateMon, 11 Mar 2019 12:10:20 +0000
treeherdermozilla-release@9c35dcbaa899 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbc
bugs1520282
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1520282 - When launching android emulator from mach, use a new pipe to stdin; r=bc
testing/mozbase/mozrunner/mozrunner/devices/android_device.py
--- a/testing/mozbase/mozrunner/mozrunner/devices/android_device.py
+++ b/testing/mozbase/mozrunner/mozrunner/devices/android_device.py
@@ -569,17 +569,17 @@ class AndroidEmulator(object):
         log_path = os.path.join(EMULATOR_HOME_DIR, 'emulator.log')
         self.emulator_log = open(log_path, 'w')
         _log_debug("Starting the emulator with this command: %s" %
                    ' '.join(command))
         _log_debug("Emulator output will be written to '%s'" %
                    log_path)
         self.proc = ProcessHandler(
             command, storeOutput=False, processOutputLine=outputHandler,
-            env=env, ignore_children=True)
+            stdin=subprocess.PIPE, env=env, ignore_children=True)
         self.proc.run()
         _log_debug("Emulator started with pid %d" %
                    int(self.proc.proc.pid))
 
     def wait_for_start(self):
         """
            Verify that the emulator is running, the emulator device is visible
            to adb, and Android has booted.