Bug 1549859 - set the app.update.BITS.inTrialGroup pref in app update xpcshell tests. r=bytesized
authorRobert Strong <robert.bugzilla@gmail.com>
Tue, 07 May 2019 22:21:51 +0000
changeset 534863 ca68ded1df00ba9848076b8b9db98e04f6bcd51b
parent 534862 f6ee274063e3a4f00cd121f8135a1f102f678e8a
child 534864 0e9e744accd3ed7b7b0ff2436904ed78a92bf9e2
push id2082
push userffxbld-merge
push dateMon, 01 Jul 2019 08:34:18 +0000
treeherdermozilla-release@2fb19d0466d2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbytesized
bugs1549859
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1549859 - set the app.update.BITS.inTrialGroup pref in app update xpcshell tests. r=bytesized This causes downloadInterruptedNoRecovery.js to intermittently fail on comm-central since BITS ends up enabled. Differential Revision: https://phabricator.services.mozilla.com/D30284
toolkit/mozapps/update/tests/data/xpcshellUtilsAUS.js
--- a/toolkit/mozapps/update/tests/data/xpcshellUtilsAUS.js
+++ b/toolkit/mozapps/update/tests/data/xpcshellUtilsAUS.js
@@ -838,16 +838,18 @@ function setupTestCommon(aAppUpdateAutoE
         logTestInfo("non-fatal error removing directory. Path: " +
                     updatesDir.path + ", Exception: " + e);
       }
     }
   }
 
   setAppUpdateAutoSync(aAppUpdateAutoEnabled);
   Services.prefs.setBoolPref(PREF_APP_UPDATE_BITS_ENABLED, aAllowBits);
+  // Set this preference so the trial doesn't override the decision.
+  Services.prefs.setBoolPref("app.update.BITS.inTrialGroup", aAllowBits);
 
   debugDump("finish - general test setup");
   return true;
 }
 
 /**
  * Nulls out the most commonly used global vars used by tests to prevent leaks
  * as needed and attempts to restore the system to its original state.