Bug 1533842 - When creating the ContentParent object explicitly flag it as not shutting down r=Alex_Gaynor a=pascalc
☠☠ backed out by aff09871d5b9 ☠ ☠
authorGabriele Svelto <gsvelto@mozilla.com>
Mon, 18 Mar 2019 12:54:11 +0000
changeset 525646 ca6825d7be210e4a1282a92a3ba9b24ffef976a3
parent 525645 bfc174c4deb853203c5cf7d1c94571f9878d6d21
child 525647 20c6fef1599eae9f5629f08ec19c04cf05acad47
push id2032
push userffxbld-merge
push dateMon, 13 May 2019 09:36:57 +0000
treeherdermozilla-release@455c1065dcbe [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersAlex_Gaynor, pascalc
bugs1533842
milestone67.0
Bug 1533842 - When creating the ContentParent object explicitly flag it as not shutting down r=Alex_Gaynor a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D23740
dom/ipc/ContentParent.cpp
--- a/dom/ipc/ContentParent.cpp
+++ b/dom/ipc/ContentParent.cpp
@@ -2263,16 +2263,17 @@ ContentParent::ContentParent(ContentPare
       mOpener(aOpener),
       mRemoteType(aRemoteType),
       mChildID(gContentChildID++),
       mGeolocationWatchID(-1),
       mJSPluginID(aJSPluginID),
       mRemoteWorkerActors(0),
       mNumDestroyingTabs(0),
       mLifecycleState(LifecycleState::LAUNCHING),
+      mShuttingDown(false),
       mIsForBrowser(!mRemoteType.IsEmpty()),
       mRecordReplayState(aRecordReplayState),
       mRecordingFile(aRecordingFile),
       mCalledClose(false),
       mCalledKillHard(false),
       mCreatedPairedMinidumps(false),
       mShutdownPending(false),
       mIPCOpen(true),
@@ -5730,17 +5731,17 @@ mozilla::ipc::IPCResult ContentParent::R
             ("ParentIPC: Trying to attach already attached 0x%08" PRIx64
              " to 0x%08" PRIx64,
              aInit.mId, aInit.mParentId));
     return IPC_OK();
   }
 
   if (!child) {
     RefPtr<BrowsingContextGroup> group =
-      BrowsingContextGroup::Select(aInit.mParentId, aInit.mOpenerId);
+        BrowsingContextGroup::Select(aInit.mParentId, aInit.mOpenerId);
     child = BrowsingContext::CreateFromIPC(std::move(aInit), group, this);
   }
 
   child->Attach(/* aFromIPC */ true);
 
   return IPC_OK();
 }