Bug 1247535 - Fix -Wunreachable-code warning in mfbt/Poison.cpp. r=froydnj
authorChris Peterson <cpeterson@mozilla.com>
Wed, 10 Feb 2016 22:09:53 -0800
changeset 322373 ca507a54c7cc0fb0126a1ac3163b4c5f47d3ce88
parent 322372 09f9cbdd14033abd220a276fd3920c1cebf96f9b
child 322374 4aa13808ef11d9373228b1abfef07c6b5b9a0962
push id1128
push userjlund@mozilla.com
push dateWed, 01 Jun 2016 01:31:59 +0000
treeherdermozilla-release@fe0d30de989d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1247535
milestone47.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1247535 - Fix -Wunreachable-code warning in mfbt/Poison.cpp. r=froydnj mfbt/Poison.cpp:165:26: warning: will never be executed [-Wunreachable-code]
mfbt/Poison.cpp
--- a/mfbt/Poison.cpp
+++ b/mfbt/Poison.cpp
@@ -187,19 +187,17 @@ ReservePoisonArea(uintptr_t rgnsize)
 
   // It didn't, so try to allocate again, without any constraint on
   // the address.
   result = ReserveRegion(0, rgnsize);
   if (result != RESERVE_FAILED) {
     return uintptr_t(result);
   }
 
-  // no usable poison region identified
-  MOZ_CRASH();
-  return 0;
+  MOZ_CRASH("no usable poison region identified");
 }
 
 void
 mozPoisonValueInit()
 {
   gMozillaPoisonSize = GetDesiredRegionSize();
   gMozillaPoisonBase = ReservePoisonArea(gMozillaPoisonSize);