Bug 1172239 - Expand height change hint to its components. r=heycam, a=lmandel
☠☠ backed out by df25d99a85a2 ☠ ☠
authorRobert O'Callahan <robert@ocallahan.org>
Fri, 17 Jul 2015 15:21:29 +1200
changeset 275472 ca0e11da35da9c610da09e8f75556fbe16a6bd0f
parent 275471 7474768be865fc363250b3e4cc8edc56df14c565
child 275473 caf429779e370589790d87b8b99aeb6f8a1150b8
push id863
push userraliiev@mozilla.com
push dateMon, 03 Aug 2015 13:22:43 +0000
treeherdermozilla-release@f6321b14228d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersheycam, lmandel
bugs1172239
milestone40.0
Bug 1172239 - Expand height change hint to its components. r=heycam, a=lmandel
layout/style/nsStyleStruct.cpp
--- a/layout/style/nsStyleStruct.cpp
+++ b/layout/style/nsStyleStruct.cpp
@@ -1596,17 +1596,20 @@ nsChangeHint nsStylePosition::CalcDiffer
       mMinHeight != aOther.mMinHeight ||
       mMaxHeight != aOther.mMaxHeight) {
     // Height changes can affect descendant intrinsic sizes due to replaced
     // elements with percentage heights in descendants which also have
     // percentage heights.  And due to our not-so-great computation of mVResize
     // in nsHTMLReflowState, they do need to force reflow of the whole subtree.
     // XXXbz due to XUL caching heights as well, height changes also need to
     // clear ancestor intrinsics!
-    return NS_CombineHint(hint, nsChangeHint_AllReflowHints);
+    return NS_CombineHint(hint, nsChangeHint_NeedReflow |
+        nsChangeHint_ClearAncestorIntrinsics |
+        nsChangeHint_ClearDescendantIntrinsics | nsChangeHint_NeedDirtyReflow |
+        nsChangeHint_ReflowChangesSizeOrPosition);
   }
 
   if (mWidth != aOther.mWidth ||
       mMinWidth != aOther.mMinWidth ||
       mMaxWidth != aOther.mMaxWidth) {
     // None of our width differences can affect descendant intrinsic
     // sizes and none of them need to force children to reflow.
     return