Backed out changeset a9c528fe96d5 (bug 1512046) for failing devtools/client/webconsole/test/mochitest/browser_webconsole_error_with_grouped_stack.json a CLOSED TREE
authorAndreea Pavel <apavel@mozilla.com>
Fri, 07 Dec 2018 01:03:29 +0200
changeset 508796 c9ff07bf8ef3e76000e14e51ffbcd65dbafcd441
parent 508795 a58e3e8aab98d849e30e42cd9f70b34695e87e61
child 508797 7f908c15daf69ea33ab6c71471f98a517e831f72
push id1905
push userffxbld-merge
push dateMon, 21 Jan 2019 12:33:13 +0000
treeherdermozilla-release@c2fca1944d8c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1512046
milestone65.0a1
backs outa9c528fe96d5df7ee16d1c9d8f84c03b04ef850b
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset a9c528fe96d5 (bug 1512046) for failing devtools/client/webconsole/test/mochitest/browser_webconsole_error_with_grouped_stack.json a CLOSED TREE
devtools/client/debugger/new/src/components/SecondaryPanes/Frames/Group.js
devtools/client/webconsole/test/mochitest/browser.ini
devtools/client/webconsole/test/mochitest/browser_webconsole_error_with_grouped_stack.js
--- a/devtools/client/debugger/new/src/components/SecondaryPanes/Frames/Group.js
+++ b/devtools/client/debugger/new/src/components/SecondaryPanes/Frames/Group.js
@@ -74,18 +74,17 @@ export default class Group extends Compo
     FrameMenu(
       frame,
       frameworkGroupingOn,
       { copyStackTrace, toggleFrameworkGrouping, toggleBlackBox },
       event
     );
   }
 
-  toggleFrames = (event) => {
-    event.stopPropagation();
+  toggleFrames = () => {
     this.setState(prevState => ({ expanded: !prevState.expanded }));
   };
 
   renderFrames() {
     const {
       group,
       selectFrame,
       selectedFrame,
--- a/devtools/client/webconsole/test/mochitest/browser.ini
+++ b/devtools/client/webconsole/test/mochitest/browser.ini
@@ -288,17 +288,16 @@ subsuite = clipboard
 [browser_webconsole_context_menu_open_url.js]
 [browser_webconsole_context_menu_store_as_global.js]
 [browser_webconsole_cors_errors.js]
 [browser_webconsole_csp_ignore_reflected_xss_message.js]
 [browser_webconsole_csp_violation.js]
 [browser_webconsole_cspro.js]
 [browser_webconsole_document_focus.js]
 [browser_webconsole_duplicate_errors.js]
-[browser_webconsole_error_with_grouped_stack.js]
 [browser_webconsole_error_with_longstring_stack.js]
 [browser_webconsole_error_with_unicode.js]
 [browser_webconsole_errors_after_page_reload.js]
 [browser_webconsole_eval_in_debugger_stackframe.js]
 [browser_webconsole_eval_in_debugger_stackframe2.js]
 [browser_webconsole_execution_scope.js]
 [browser_webconsole_external_script_errors.js]
 [browser_webconsole_file_uri.js]
deleted file mode 100644
--- a/devtools/client/webconsole/test/mochitest/browser_webconsole_error_with_grouped_stack.js
+++ /dev/null
@@ -1,35 +0,0 @@
-/* Any copyright is dedicated to the Public Domain.
- * http://creativecommons.org/publicdomain/zero/1.0/ */
-
-// Check if an error with a stack containing grouped frames works as expected.
-
-"use strict";
-
-const MESSAGE = "React Error";
-const TEST_URI = `data:text/html;charset=utf8,<script>
-  const x = new Error("${MESSAGE}");
-  x.stack = "a@http://exampl.com:1:1\\n" +
-    "grouped@http://react.js:1:1\\n" +
-    "grouped2@http://react.js:1:1";
-  console.error(x);
-</script>`;
-
-add_task(async function() {
-  const hud = await openNewTabAndConsole(TEST_URI);
-
-  info("Wait for the error to be logged");
-  const msgNode = await waitFor(() => findMessage(hud, MESSAGE));
-  ok(!msgNode.classList.contains("open"), `Error logged not expanded`);
-
-  const errorNode = msgNode.querySelector(".objectBox-stackTrace");
-  ok(errorNode, "The error object is logged as expected");
-
-  const onGroupExpanded = waitFor(() =>
-    errorNode.querySelector(".frames-group.expanded"));
-  errorNode.querySelector(".group").click();
-  await onGroupExpanded;
-
-  ok(true, "The stacktrace group was expanded");
-  is(errorNode.querySelectorAll(".frame").length, 3, "Expected frames are displayed");
-  ok(!msgNode.classList.contains("open"), `Error message is still not expanded`);
-});