Bug 1322358: Don't disable m-sections in answer just because they're inactive. r=drno
authorByron Campen [:bwc] <docfaraday@gmail.com>
Wed, 25 Jan 2017 16:42:08 -0600
changeset 380177 c913bf6e11c44d2c50d6371ce00d181c7bd39841
parent 380176 56cf0d1016b8984736b5a6f0ba8b0673db16d2f3
child 380178 a3fc19cd30d845ec32d3b17459c0dd243feaf947
push id1468
push userasasaki@mozilla.com
push dateMon, 05 Jun 2017 19:31:07 +0000
treeherdermozilla-release@0641fc6ee9d1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdrno
bugs1322358
milestone54.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1322358: Don't disable m-sections in answer just because they're inactive. r=drno MozReview-Commit-ID: 6YPwEk7bwIG
media/webrtc/signaling/src/jsep/JsepSessionImpl.cpp
--- a/media/webrtc/signaling/src/jsep/JsepSessionImpl.cpp
+++ b/media/webrtc/signaling/src/jsep/JsepSessionImpl.cpp
@@ -1000,21 +1000,16 @@ JsepSessionImpl::CreateAnswerMSection(co
     rv = BindMatchingLocalTrackToAnswer(&msection);
     NS_ENSURE_SUCCESS(rv, rv);
   }
 
   if (remoteMsection.IsSending()) {
     BindMatchingRemoteTrackToAnswer(&msection);
   }
 
-  if (!msection.IsReceiving() && !msection.IsSending()) {
-    mSdpHelper.DisableMsection(sdp, &msection);
-    return NS_OK;
-  }
-
   // Add extmap attributes.
   AddCommonExtmaps(remoteMsection, &msection);
 
   if (msection.GetFormats().empty()) {
     // Could not negotiate anything. Disable m-section.
     mSdpHelper.DisableMsection(sdp, &msection);
   }