Bug 1425599 part 10 - [css-grid] Make MarkExcludedTracks a static method since it doesn't use 'this' (idempotent change). r=dholbert a=jcristau
authorMats Palmgren <mats@mozilla.com>
Thu, 15 Mar 2018 22:41:24 +0100
changeset 462724 c8c86f719155e279cb7e2d102aaaa07dd12278cd
parent 462723 6dba9c6e951f01da0e34f57da853a739c9dc29df
child 462725 f542fec596d962d589b76eb3ce3a44ad7f5db448
push id1683
push usersfraser@mozilla.com
push dateThu, 26 Apr 2018 16:43:40 +0000
treeherdermozilla-release@5af6cb21869d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdholbert, jcristau
bugs1425599
milestone60.0
Bug 1425599 part 10 - [css-grid] Make MarkExcludedTracks a static method since it doesn't use 'this' (idempotent change). r=dholbert a=jcristau
layout/generic/nsGridContainerFrame.cpp
--- a/layout/generic/nsGridContainerFrame.cpp
+++ b/layout/generic/nsGridContainerFrame.cpp
@@ -1371,22 +1371,23 @@ struct nsGridContainerFrame::Tracks
   /**
    * Helper for GrowSelectedTracksUnlimited.  For the set of tracks (S) that
    * match aMinSizingSelector: if a track in S doesn't match aMaxSizingSelector
    * then mark it with aSkipFlag.  If all tracks in S were marked then unmark
    * them.  Return aNumGrowable minus the number of tracks marked.  It is
    * assumed that aPlan have no aSkipFlag set for tracks in aGrowableTracks
    * on entry to this method.
    */
-   uint32_t MarkExcludedTracks(nsTArray<TrackSize>&      aPlan,
-                               uint32_t                  aNumGrowable,
-                               const nsTArray<uint32_t>& aGrowableTracks,
-                               TrackSize::StateBits      aMinSizingSelector,
-                               TrackSize::StateBits      aMaxSizingSelector,
-                               TrackSize::StateBits      aSkipFlag) const
+   static uint32_t
+   MarkExcludedTracks(nsTArray<TrackSize>&      aPlan,
+                      uint32_t                  aNumGrowable,
+                      const nsTArray<uint32_t>& aGrowableTracks,
+                      TrackSize::StateBits      aMinSizingSelector,
+                      TrackSize::StateBits      aMaxSizingSelector,
+                      TrackSize::StateBits      aSkipFlag)
   {
     bool foundOneSelected = false;
     bool foundOneGrowable = false;
     uint32_t numGrowable = aNumGrowable;
     for (uint32_t track : aGrowableTracks) {
       TrackSize& sz = aPlan[track];
       const auto state = sz.mState;
       if (state & aMinSizingSelector) {