Bug 1398142 - Always specify .tab-throbber size so that pinned tabs can be positioned correctly before the session has been restored. r=jaws, a=ritu
authorDão Gottwald <dao@mozilla.com>
Fri, 20 Oct 2017 13:09:00 +0200
changeset 435120 c8c16ef5be63d4803b3bbe0194f745d3ba582d2c
parent 435119 09539becfa9a68096205fa70f7b5b8686fcc79f5
child 435121 598d726067c4fa4718fcc09cdf3e5f6b9b0b6eae
push id1567
push userjlorenzo@mozilla.com
push dateThu, 02 Nov 2017 12:36:05 +0000
treeherdermozilla-release@e512c14a0406 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjaws, ritu
bugs1398142
milestone57.0
Bug 1398142 - Always specify .tab-throbber size so that pinned tabs can be positioned correctly before the session has been restored. r=jaws, a=ritu MozReview-Commit-ID: 6u1jR93EMu2
browser/themes/shared/tabs.inc.css
--- a/browser/themes/shared/tabs.inc.css
+++ b/browser/themes/shared/tabs.inc.css
@@ -137,21 +137,32 @@ tabbrowser {
 .tab-throbber,
 .tab-icon-image,
 .tab-sharing-icon-overlay,
 .tab-icon-sound,
 .tab-close-button {
   margin-top: 1px;
 }
 
+.tab-throbber,
+.tab-icon-image,
+.tab-sharing-icon-overlay {
+  height: 16px;
+  width: 16px;
+}
+
+.tab-throbber:not([pinned]),
+.tab-sharing-icon-overlay:not([pinned]),
+.tab-icon-image:not([pinned]) {
+  margin-inline-end: 6px;
+}
+
 :root[sessionrestored] .tab-throbber[busy] {
   position: relative;
   overflow: hidden;
-  width: 16px;
-  height: 16px;
 }
 
 :root[sessionrestored] .tab-throbber[busy]::before {
   content: "";
   position: absolute;
   background-image: url("chrome://browser/skin/tabbrowser/loading.svg");
   background-position: left center;
   background-repeat: no-repeat;
@@ -186,28 +197,16 @@ tabbrowser {
   fill: var(--tab-loading-fill);
   opacity: 1;
 }
 
 #TabsToolbar[brighttext] .tabbrowser-tab:not([visuallyselected=true]) {
   --tab-loading-fill: #fff;
 }
 
-.tab-sharing-icon-overlay,
-.tab-icon-image {
-  height: 16px;
-  width: 16px;
-}
-
-.tab-throbber:not([pinned]),
-.tab-sharing-icon-overlay:not([pinned]),
-.tab-icon-image:not([pinned]) {
-  margin-inline-end: 6px;
-}
-
 .tab-icon-image {
   list-style-image: url("chrome://mozapps/skin/places/defaultFavicon.svg");
 }
 
 .tab-icon-image[src^="chrome://"] {
   -moz-context-properties: fill;
   fill: currentColor;
 }