Bug 1496297 - Use |jit-test| skip-if as appropriate in jit-test/tests/ (r=jorendorff)
authorEric Faust <efausbmo@gmail.com>
Tue, 09 Oct 2018 15:41:50 -0700
changeset 498849 c8b420c49253532689f462813d7c9673ba798165
parent 498848 179b81691182a23085d1bd73931e4d86842677f8
child 498850 8f0aa41876197fc701ddadb73eee8edaa753af19
push id1864
push userffxbld-merge
push dateMon, 03 Dec 2018 15:51:40 +0000
treeherdermozilla-release@f040763d99ad [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjorendorff
bugs1496297
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1496297 - Use |jit-test| skip-if as appropriate in jit-test/tests/ (r=jorendorff)
js/src/jit-test/tests/bug1213574.js
js/src/jit-test/tests/bug1366925.js
js/src/jit-test/tests/bug1490638.js
--- a/js/src/jit-test/tests/bug1213574.js
+++ b/js/src/jit-test/tests/bug1213574.js
@@ -1,10 +1,9 @@
-if (helperThreadCount() === 0)
-    quit(0);
+// |jit-test| skip-if: helperThreadCount() === 0
 
 var lfGlobal = newGlobal();
 lfGlobal.offThreadCompileScript(`{ let x; throw 42; }`);
 try {
     lfGlobal.runOffThreadScript();
 } catch (e) {
 }
 
--- a/js/src/jit-test/tests/bug1366925.js
+++ b/js/src/jit-test/tests/bug1366925.js
@@ -1,10 +1,9 @@
-// JS shell shutdown ordering
-
+// |jit-test| skip-if: helperThreadCount() === 0
 // Avoid crashing with --no-threads
-if (helperThreadCount() == 0)
-  quit();
+
+// JS shell shutdown ordering
 
 evalInWorker(`
   var lfGlobal = newGlobal();
   lfGlobal.offThreadCompileScript(\`{ let x; throw 42; }\`);
 `);
--- a/js/src/jit-test/tests/bug1490638.js
+++ b/js/src/jit-test/tests/bug1490638.js
@@ -1,10 +1,8 @@
-// |jit-test| allow-overrecursed
-if (helperThreadCount() == 0)
-    quit();
+// |jit-test| allow-overrecursed; skip-if: helperThreadCount() === 0
 
 evalInWorker(`
   function f() {
     f.apply([], new Array(20000));
   }
   f()
 `);