Bug 1510391 - When a task is not found, don't add None to the list of tasks to run. r=ahal
authorMarco Castelluccio <mcastelluccio@mozilla.com>
Tue, 27 Nov 2018 17:29:34 +0100
changeset 507998 c8752ec31af8548218ecf577b5132a5705c30bd7
parent 507997 82bbee36c7dc5273252d761b6ec66da6f2b0ead5
child 507999 c58b7f9f87735d9f86489ebf4a0cc1a80cb00048
push id1905
push userffxbld-merge
push dateMon, 21 Jan 2019 12:33:13 +0000
treeherdermozilla-release@c2fca1944d8c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersahal
bugs1510391
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1510391 - When a task is not found, don't add None to the list of tasks to run. r=ahal
tools/tryselect/selectors/coverage.py
--- a/tools/tryselect/selectors/coverage.py
+++ b/tools/tryselect/selectors/coverage.py
@@ -325,18 +325,18 @@ def filter_tasks_by_chunks(tasks, chunks
             if not any(task[len(platform) + 1:].endswith(c) for c in [chunk, chunk + '-e10s']):
                 continue
 
             assert selected_task is None, 'Only one task should be selected for a given platform-chunk couple ({} - {}), {} and {} were selected'.format(platform, chunk, selected_task, task)  # noqa
             selected_task = task
 
         if selected_task is None:
             print('Warning: no task found for chunk', platform, chunk)
-
-        selected_tasks.add(selected_task)
+        else:
+            selected_tasks.add(selected_task)
 
     return list(selected_tasks)
 
 
 def is_opt_task(task):
     '''True if the task runs on a supported platform and build type combination.
     This is used to remove -ccov/asan/pgo tasks, along with all /debug tasks.
     '''