Backed out changeset 5856e2411504 (bug 1510985) for landing a partial patch
authorJulien Cristau <jcristau@mozilla.com>
Mon, 03 Dec 2018 15:23:07 -0500
changeset 501448 c814d6d044cc
parent 501447 05dcb777fbc3
child 501449 80a34446b74a
push id1867
push userjcristau@mozilla.com
push dateMon, 03 Dec 2018 20:26:53 +0000
treeherdermozilla-release@80a34446b74a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1510985
milestone64.0
backs out5856e2411504
Backed out changeset 5856e2411504 (bug 1510985) for landing a partial patch
dom/base/DOMPrefsInternal.h
dom/webidl/Event.webidl
modules/libpref/init/StaticPrefList.h
testing/web-platform/meta/dom/interfaces.html.ini
--- a/dom/base/DOMPrefsInternal.h
+++ b/dom/base/DOMPrefsInternal.h
@@ -11,17 +11,16 @@
 //   DOM_WEBIDL_PREF(foo_bar)
 //
 //   * This defines DOMPrefs::foo_bar(JSContext* aCx, JSObject* aObj) which
 //     returns the value of StaticPrefs::foo_bar().
 //     This is allows the use of DOMPrefs in WebIDL files.
 
 DOM_WEBIDL_PREF(canvas_imagebitmap_extensions_enabled)
 DOM_WEBIDL_PREF(dom_caches_enabled)
-DOM_WEBIDL_PREF(dom_event_returnValue_enabled)
 DOM_WEBIDL_PREF(dom_webnotifications_serviceworker_enabled)
 DOM_WEBIDL_PREF(dom_webnotifications_requireinteraction_enabled)
 DOM_WEBIDL_PREF(dom_serviceWorkers_enabled)
 DOM_WEBIDL_PREF(dom_storageManager_enabled)
 DOM_WEBIDL_PREF(dom_testing_structuredclonetester_enabled)
 DOM_WEBIDL_PREF(dom_promise_rejection_events_enabled)
 DOM_WEBIDL_PREF(dom_push_enabled)
 DOM_WEBIDL_PREF(gfx_offscreencanvas_enabled)
--- a/dom/webidl/Event.webidl
+++ b/dom/webidl/Event.webidl
@@ -31,18 +31,17 @@ interface Event {
 
   void stopPropagation();
   void stopImmediatePropagation();
 
   [Pure]
   readonly attribute boolean bubbles;
   [Pure]
   readonly attribute boolean cancelable;
-  [NeedsCallerType,
-   Func="mozilla::dom::DOMPrefs::dom_event_returnValue_enabled"]
+  [NeedsCallerType]
   attribute boolean returnValue;
   [NeedsCallerType]
   void preventDefault();
   [Pure, NeedsCallerType]
   readonly attribute boolean defaultPrevented;
   [ChromeOnly, Pure]
   readonly attribute boolean defaultPreventedByChrome;
   [ChromeOnly, Pure]
--- a/modules/libpref/init/StaticPrefList.h
+++ b/modules/libpref/init/StaticPrefList.h
@@ -174,23 +174,16 @@ VARCACHE_PREF(
 #endif
 VARCACHE_PREF(
   "dom.animations-api.timelines.enabled",
    dom_animations_api_timelines_enabled,
   bool, PREF_VALUE
 )
 #undef PREF_VALUE
 
-// If this is true, event.returnValue is available.
-VARCACHE_PREF(
-  "dom.event.returnValue.enabled",
-   dom_event_returnValue_enabled,
-  RelaxedAtomicBool, false
-)
-
 // How long a content process can take before closing its IPC channel
 // after shutdown is initiated.  If the process exceeds the timeout,
 // we fear the worst and kill it.
 #if !defined(DEBUG) && !defined(MOZ_ASAN) && !defined(MOZ_VALGRIND) && \
     !defined(MOZ_TSAN)
 # define PREF_VALUE 5
 #else
 # define PREF_VALUE 0
--- a/testing/web-platform/meta/dom/interfaces.html.ini
+++ b/testing/web-platform/meta/dom/interfaces.html.ini
@@ -82,55 +82,31 @@
     expected: FAIL
 
   [Range interface: existence and properties of interface object]
     expected: FAIL
 
   [Range interface: existence and properties of interface prototype object]
     expected: FAIL
 
-  [Event interface: attribute returnValue]
-    expected: FAIL
-
-  [Event interface: document.createEvent("Event") must inherit property "returnValue" with the proper type]
-    expected: FAIL
-
-  [Event interface: new Event("foo") must inherit property "returnValue" with the proper type]
-    expected: FAIL
-
-  [Event interface: new CustomEvent("foo") must inherit property "returnValue" with the proper type]
-    expected: FAIL
 
 [interfaces.html?1-1000]
   [Test driver]
     expected: FAIL
 
 
 [interfaces.html?1001-last]
   [Test driver]
     expected: FAIL
 
 
 [interfaces.html?exclude=Node]
   [Test driver]
     expected: FAIL
 
-[interfaces.html?exclude=Node]
-  [Event interface: attribute returnValue]
-    expected: FAIL
-
-  [Event interface: document.createEvent("Event") must inherit property "returnValue" with the proper type]
-    expected: FAIL
-
-  [Event interface: new Event("foo") must inherit property "returnValue" with the proper type]
-    expected: FAIL
-
-  [Event interface: new CustomEvent("foo") must inherit property "returnValue" with the proper type]
-    expected: FAIL
-
   [Document interface: attribute origin]
     expected: FAIL
 
   [Document interface: new Document() must inherit property "origin" with the proper type]
     expected: FAIL
 
   [Document interface: xmlDoc must inherit property "origin" with the proper type]
     expected: FAIL
@@ -192,28 +168,16 @@
   [Range interface: existence and properties of interface prototype object]
     expected: FAIL
 
 
 [interfaces.html?include=Node]
 
 [interfaces.html?exclude=Node]
   prefs: [dom.window.event.enabled:true]
-  [Event interface: attribute returnValue]
-    expected: FAIL
-
-  [Event interface: document.createEvent("Event") must inherit property "returnValue" with the proper type]
-    expected: FAIL
-
-  [Event interface: new Event("foo") must inherit property "returnValue" with the proper type]
-    expected: FAIL
-
-  [Event interface: new CustomEvent("foo") must inherit property "returnValue" with the proper type]
-    expected: FAIL
-
   [Document interface: attribute origin]
     expected: FAIL
 
   [Document interface: new Document() must inherit property "origin" with the proper type]
     expected: FAIL
 
   [Document interface: xmlDoc must inherit property "origin" with the proper type]
     expected: FAIL