Bug 1575841 [wpt PR 18612] - Revert "[CSS] Treat viewport-relative units as computationally independent", a=testonly
authorEmil A Eklund <eae@chromium.org>
Mon, 26 Aug 2019 11:29:24 +0000
changeset 553978 c6141012a736a409c71006910632fd8a477f3b73
parent 553977 73225a9e209478b617cfc3024ed0523425e3efce
child 553979 ffeb51048e9b089ec1a2899bbf11dbcca798b201
push id2165
push userffxbld-merge
push dateMon, 14 Oct 2019 16:30:58 +0000
treeherdermozilla-release@0eae18af659f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1575841, 18612, 993476, 1764195, 689475
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1575841 [wpt PR 18612] - Revert "[CSS] Treat viewport-relative units as computationally independent", a=testonly Automatic update from web-platform-tests Revert "[CSS] Treat viewport-relative units as computationally independent" This is a speculative revert in order to either confirm or eliminate it as a source for a hard to track down persistent performance regression. This reverts r679183 (commit 6b846d3689b9038c73d87ecbab61670e91c7e051). Bug: 993476 Tbr: pdr@chromium.org Change-Id: I37566d32fb0853590e72299fdc0f281c712bf027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764195 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#689475} -- wpt-commits: 7c8e32ead1a5cc9b402558fd43d0c555bd31965f wpt-pr: 18612
testing/web-platform/tests/css/css-properties-values-api/register-property-syntax-parsing.html
--- a/testing/web-platform/tests/css/css-properties-values-api/register-property-syntax-parsing.html
+++ b/testing/web-platform/tests/css/css-properties-values-api/register-property-syntax-parsing.html
@@ -49,18 +49,16 @@ assert_valid("<length>", "calc(2px*4 + 1
 assert_valid("<length>", "7.1e-4cm");
 assert_valid("<length>", "calc(7in - 12px)");
 assert_valid("<length>+", "2px 7px calc(8px)");
 assert_valid("<length>#", "2px, 7px, calc(8px)");
 assert_valid("<percentage>", "-9.3e3%");
 assert_valid("<length-percentage>", "-54%");
 assert_valid("<length-percentage>", "0");
 assert_valid("<length-percentage>", "calc(-11px + 10.4%)");
-assert_valid("<length>", "10vmin");
-assert_valid("<percentage> | <length>+", "calc(100vh - 10px) 30px");
 
 assert_valid("<number>", "-109");
 assert_valid("<number>", "2.3e4");
 assert_valid("<integer>", "-109");
 assert_valid("<integer>", "19");
 assert_valid("<integer>", "calc(1)");
 assert_valid("<integer>", "calc(1 + 2)");
 assert_valid("<integer>", "calc(3.1415)");
@@ -180,22 +178,24 @@ assert_invalid("*", "var(--foo)");
 
 assert_invalid("banana", "bAnAnA");
 assert_invalid("<length>", "var(--moo)");
 assert_invalid("<length>", "10");
 assert_invalid("<length>", "10%");
 assert_invalid("<length>", "calc(5px + 10%)");
 assert_invalid("<length>", "calc(5px * 3px / 6px)");
 assert_invalid("<length>", "10em");
+assert_invalid("<length>", "10vmin");
 assert_invalid("<length>", "calc(4px + 3em)");
 assert_invalid("<length>", "calc(4px + calc(8 * 2em))");
 assert_invalid("<length>+", "calc(2ex + 16px)");
 assert_invalid("<length>+", "10px calc(20px + 4rem)");
 assert_invalid("<length>+", "");
 assert_invalid("<length>#", "");
+assert_invalid("<percentage> | <length>+", "calc(100vh - 10px) 30px");
 assert_invalid("<length>", "10px;");
 assert_invalid("<length-percentage>", "calc(2px + 10% + 7ex)");
 assert_invalid("<percentage>", "0");
 assert_invalid("<integer>", "1.0");
 assert_invalid("<integer>", "1e0");
 assert_invalid("<number>|foo", "foo var(--foo, bla)");
 assert_invalid("Foo | bar", "foo");
 assert_invalid("Foo | bar", "Bar");