Bug 1522092 - Disable PanelMultiView's keyboard navigation code for the Site Identity panel. r=johannh a=lizzard
authorBogdan Tara <btara@mozilla.com>
Sat, 09 Mar 2019 05:43:26 +0200
changeset 516341 c4d0a83454a291d01e5c8d2f9215a2d43c890562
parent 516340 0bc584b08a5f13eef5686c63cca8bfd3698b8c6e
child 516342 93d78ef4e591cb9b980605691051abadaca9d773
push id1953
push userffxbld-merge
push dateMon, 11 Mar 2019 12:10:20 +0000
treeherdermozilla-release@9c35dcbaa899 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjohannh, lizzard
bugs1522092
milestone66.0
Bug 1522092 - Disable PanelMultiView's keyboard navigation code for the Site Identity panel. r=johannh a=lizzard Summary: PanelMultiView's keyboard navigation code currently overrides the arrow keys in menulists. This breaks the permission selectors in the Site Identity panel. For now, just disable this keyboard navigation code. DOM will then handle tabbing as it normally would. This panel is more like a dialog than a menu, so users will generally navigate it with the tab key rather than the arrow keys anyway. Note that the code in PanelMultiView which makes controls focusable still runs even with disablekeynav set, which is what we want. Reviewers: johannh Reviewed By: johannh Bug #: 1522092 Differential Revision: https://phabricator.services.mozilla.com/D21484
browser/components/controlcenter/content/panel.inc.xul
--- a/browser/components/controlcenter/content/panel.inc.xul
+++ b/browser/components/controlcenter/content/panel.inc.xul
@@ -8,17 +8,18 @@
        photon="true"
        role="alertdialog"
        aria-labelledby="identity-popup-mainView-panel-header-span"
        onpopupshown="gIdentityHandler.onPopupShown(event);"
        onpopuphidden="gIdentityHandler.onPopupHidden(event);"
        orient="vertical">
 
   <panelmultiview id="identity-popup-multiView"
-                  mainViewId="identity-popup-mainView">
+                  mainViewId="identity-popup-mainView"
+                  disablekeynav="true">
     <panelview id="identity-popup-mainView"
                descriptionheightworkaround="true">
       <vbox id="identity-popup-mainView-panel-header">
         <label>
           <html:span id="identity-popup-mainView-panel-header-span"/>
         </label>
       </vbox>