Bug 1499196 - Use outputs as the key for rust commands in Tup once again. r=mshal
authorChris Manchester <cmanchester@mozilla.com>
Sun, 21 Oct 2018 18:56:23 +0000
changeset 500770 c43c91d2b97b1d1b230efdabce8b67d52e5cda27
parent 500769 caaad097961a2566dff3742bf57b36085ce3bab6
child 500779 b2fa4b07f6f7e489047808bd0238301ea943b4b3
push id1864
push userffxbld-merge
push dateMon, 03 Dec 2018 15:51:40 +0000
treeherdermozilla-release@f040763d99ad [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmshal
bugs1499196
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1499196 - Use outputs as the key for rust commands in Tup once again. r=mshal Now that we're outputing a stub file for each build script we can index these commands by their output to de-duplicate them in the tup backend. Differential Revision: https://phabricator.services.mozilla.com/D9042
python/mozbuild/mozbuild/backend/tup.py
--- a/python/mozbuild/mozbuild/backend/tup.py
+++ b/python/mozbuild/mozbuild/backend/tup.py
@@ -961,17 +961,17 @@ class TupBackend(CommonBackend):
                 header = 'RUSTC'
             else:
                 inputs.add(invocation['program'])
                 header = 'RUN'
 
             invocation['full-deps'].update(inputs)
             invocation['full-deps'].update(invocation['outputs'])
 
-            cmd_key = ' '.join(command)
+            cmd_key = ' '.join(outputs)
             if cmd_key not in self._rust_cmds:
                 self._rust_cmds.add(cmd_key)
                 # We have some custom build scripts that depend on python code
                 # as well as invalidate a lot of the rust build, so set
                 # check_unchanged to try to reduce long incremental builds
                 # when only changing python.
                 check_unchanged = False
                 if (invocation['target_kind'][0] == 'custom-build' and