Bug 1345654 - Enable client-side stack-walking on beta and release for main process crashes r=bsmedberg a=gchang
authorGabriele Svelto <gsvelto@mozilla.com>
Thu, 09 Mar 2017 14:53:54 +0100
changeset 379088 c385ff88725dd45405c7cd52feb4ed6604946a1c
parent 379087 bc68e859eb66508642aa27950f9c1fd6d8c40a8c
child 379089 b29177eab57933cadcfc09a3c9dad7d3fa67165d
push id1419
push userjlund@mozilla.com
push dateMon, 10 Apr 2017 20:44:07 +0000
treeherdermozilla-release@5e6801b73ef6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbsmedberg, gchang
bugs1345654
milestone53.0
Bug 1345654 - Enable client-side stack-walking on beta and release for main process crashes r=bsmedberg a=gchang MozReview-Commit-ID: APj6VBIW3l3
toolkit/crashreporter/client/crashreporter.cpp
--- a/toolkit/crashreporter/client/crashreporter.cpp
+++ b/toolkit/crashreporter/client/crashreporter.cpp
@@ -508,31 +508,27 @@ void RewriteStrings(StringTable& queryPa
 
 bool CheckEndOfLifed(string version)
 {
   string reportPath =
     gSettingsPath + UI_DIR_SEPARATOR + "EndOfLife" + version;
   return UIFileExists(reportPath);
 }
 
-#ifndef RELEASE_OR_BETA
-
 static string
 GetMinidumpAnalyzerPath()
 {
   string path = gArgv[0];
   size_t pos = path.rfind(UI_CRASH_REPORTER_FILENAME BIN_SUFFIX);
   path.erase(pos);
   path.append(UI_MINIDUMP_ANALYZER_FILENAME BIN_SUFFIX);
 
   return path;
 }
 
-#endif
-
 int main(int argc, char** argv)
 {
   gArgc = argc;
   gArgv = argv;
 
   if (!ReadConfig()) {
     UIError("Couldn't read configuration.");
     return 0;
@@ -544,21 +540,18 @@ int main(int argc, char** argv)
   if (argc > 1) {
     gReporterDumpFile = argv[1];
   }
 
   if (gReporterDumpFile.empty()) {
     // no dump file specified, run the default UI
     UIShowDefaultUI();
   } else {
-#ifndef RELEASE_OR_BETA
-    // start by running minidump analyzer, this is currently enabled only in
-    // nightly and aurora
+    // Start by running minidump analyzer to gather stack traces.
     UIRunMinidumpAnalyzer(GetMinidumpAnalyzerPath(), gReporterDumpFile);
-#endif
 
     // go ahead with the crash reporter
     gExtraFile = GetAdditionalFilename(gReporterDumpFile, kExtraDataExtension);
     if (gExtraFile.empty()) {
       UIError(gStrings[ST_ERROR_BADARGUMENTS]);
       return 0;
     }