Backed out changeset 30accf21bb0a (bug 1510214) perma failing org.mozilla.geckoview.test.AccessibilityTest.testScroll CLOSED TREE
authorBogdan Tara <btara@mozilla.com>
Thu, 29 Nov 2018 07:51:59 +0200
changeset 507880 c302586458e0a418e972652dfc4351380066c319
parent 507879 59ff6b57e94e0d31c8cab5d1f4d92b6aeb0de832
child 507895 d99bf39f5223abe554a629a947eee344c3e9e29e
child 507896 3ea2a2c78bf4454226971e87036de12fafeadc4c
push id1905
push userffxbld-merge
push dateMon, 21 Jan 2019 12:33:13 +0000
treeherdermozilla-release@c2fca1944d8c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1510214
milestone65.0a1
backs out30accf21bb0afe33b1459daa2dd80340fb05cb87
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 30accf21bb0a (bug 1510214) perma failing org.mozilla.geckoview.test.AccessibilityTest.testScroll CLOSED TREE
dom/base/nsViewportInfo.h
dom/base/test/test_meta_viewport0.html
layout/reftests/meta-viewport/clamped-by-default-minimum-scale.html
layout/reftests/meta-viewport/initial-scale-0_25-ref.html
layout/reftests/meta-viewport/reftest.list
--- a/dom/base/nsViewportInfo.h
+++ b/dom/base/nsViewportInfo.h
@@ -7,17 +7,17 @@
 
 #include <stdint.h>
 #include "mozilla/Attributes.h"
 #include "Units.h"
 
 /**
  * Default values for the nsViewportInfo class.
  */
-static const mozilla::LayoutDeviceToScreenScale kViewportMinScale(0.25f);
+static const mozilla::LayoutDeviceToScreenScale kViewportMinScale(0.1f);
 static const mozilla::LayoutDeviceToScreenScale kViewportMaxScale(10.0f);
 static const mozilla::CSSIntSize kViewportMinSize(200, 40);
 static const mozilla::CSSIntSize kViewportMaxSize(10000, 10000);
 
 /**
  * Information retrieved from the <meta name="viewport"> tag. See
  * nsIDocument::GetViewportInfo for more information on this functionality.
  */
--- a/dom/base/test/test_meta_viewport0.html
+++ b/dom/base/test/test_meta_viewport0.html
@@ -16,23 +16,23 @@
     function fuzzeq(a, b, msg) {
       ok(Math.abs(a - b) < 1e-6, msg);
     }
 
     add_task(async function test1() {
       await SpecialPowers.pushPrefEnv(scaleRatio(1.0));
 
       let info = getViewportInfo(800, 480);
-      fuzzeq(info.defaultZoom, 0.25, "initial scale is clamped to the default mimumim scale");
-      fuzzeq(info.minZoom, 0.25,     "minimum scale defaults to the absolute minimum");
-      is(info.maxZoom,     10,       "maximum scale defaults to the absolute maximum");
-      is(info.width,       980,      "width is the default width");
-      is(info.height,      588,      "height is proportional to displayHeight");
-      is(info.autoSize,    false,    "autoSize is disabled by default");
-      is(info.allowZoom,   true,     "zooming is enabled by default");
+      fuzzeq(info.defaultZoom, 0.1, "initial scale is unspecified");
+      fuzzeq(info.minZoom, 0.1,     "minimum scale defaults to the absolute minimum");
+      is(info.maxZoom,     10,      "maximum scale defaults to the absolute maximum");
+      is(info.width,       980,     "width is the default width");
+      is(info.height,      588,     "height is proportional to displayHeight");
+      is(info.autoSize,    false,   "autoSize is disabled by default");
+      is(info.allowZoom,   true,    "zooming is enabled by default");
 
       info = getViewportInfo(490, 600);
       is(info.width,       980,     "width is still the default width");
       is(info.height,      1200,    "height is proportional to the new displayHeight");
     });
 
     add_task(async function test2() {
       await SpecialPowers.pushPrefEnv(scaleRatio(1.5));
deleted file mode 100644
--- a/layout/reftests/meta-viewport/clamped-by-default-minimum-scale.html
+++ /dev/null
@@ -1,34 +0,0 @@
-<!DOCTYPE html>
-<meta name="viewport" content="width=device-width">
-<style>
-html, body {
-  margin: 0;
-  width: 100%;
-  height: 100%;
-  scrollbar-width: none;
-}
-#container {
-  /*
-   * This value should be greater than reftest viewport width 800px * (1 / 0.25).
-   * 0.25 is the initial scale value used in the reference.
-   */
-  min-width: 4000px;
-  /*
-   * This value should be greater than reftest viewport height
-   * 1000x * (1 / 0.25) to make the initial scale auto-calculation happen.
-   */
-  min-height: 8000px;
-  position: relative;
-}
-#inner {
-  position: absolute;
-  top: 0;
-  left: 0;
-  width: 100px;
-  height: 100px;
-  background: green;
-}
-</style>
-<div id="container">
-  <div id="inner"></div>
-</div>
deleted file mode 100644
--- a/layout/reftests/meta-viewport/initial-scale-0_25-ref.html
+++ /dev/null
@@ -1,23 +0,0 @@
-<!DOCTYPE html>
-<meta name="viewport" content="initial-scale=0.25,width=device-width">
-<style>
-html, body {
-  margin: 0;
-  width: 100%;
-  height: 100%;
-}
-#container {
-  position: relative;
-}
-#inner {
-  position: absolute;
-  top: 0;
-  left: 0;
-  width: 100px;
-  height: 100px;
-  background: green;
-}
-</style>
-<div id="container">
-  <div id="inner"></div>
-</div>
--- a/layout/reftests/meta-viewport/reftest.list
+++ b/layout/reftests/meta-viewport/reftest.list
@@ -3,9 +3,8 @@ default-preferences pref(dom.meta-viewpo
 # These tests assume that viewport width in reftest is 800px.
 == box-shadow.html initial-scale-0_5-ref.html
 == initial-scale-0.html initial-scale-0_5-ref.html
 == initial-scale-100.html initial-scale-0_5-ref.html
 == no-viewport.html initial-scale-0_5-ref.html
 == viewport-width.html initial-scale-0_5-ref.html
 == initial-scale-1.html no-zoom-ref.html
 == minimum-scale.html no-zoom-ref.html
-== clamped-by-default-minimum-scale.html initial-scale-0_25-ref.html