Bug 1332648 - remove bogus string radix/case #defines; r=erahm
authorNathan Froyd <froydnj@mozilla.com>
Fri, 20 Jan 2017 16:37:35 -0500
changeset 377773 c20b49c1ff854f0c38546bafbbd74b622cd8dec5
parent 377772 c60c180ba26b9cb482112123ff5c165cd527a223
child 377774 5f42a80cee038ae943ba4d3f6278208e0350fc3c
push id1419
push userjlund@mozilla.com
push dateMon, 10 Apr 2017 20:44:07 +0000
treeherdermozilla-release@5e6801b73ef6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerserahm
bugs1332648
milestone53.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1332648 - remove bogus string radix/case #defines; r=erahm Nothing uses these defines, so we should remove them lest anybody get confused. I would have also removed kAutoDetect (who would want to do this?!), but kAutoDetect is used in one place in the tree, and I didn't want to hold up the deletion of these two items with trying to fix that one place.
xpcom/string/nsString.h
--- a/xpcom/string/nsString.h
+++ b/xpcom/string/nsString.h
@@ -20,18 +20,16 @@
 #define MOZ_STRING_WITH_OBSOLETE_API 1
 #endif
 
 #if MOZ_STRING_WITH_OBSOLETE_API
 // radix values for ToInteger/AppendInt
 #define kRadix10        (10)
 #define kRadix16        (16)
 #define kAutoDetect     (100)
-#define kRadixUnknown   (kAutoDetect+1)
-#define IGNORE_CASE     (true)
 #endif
 
 
 // declare nsString, et. al.
 #include "string-template-def-unichar.h"
 #include "nsTString.h"
 #include "string-template-undef.h"