Bug 1409904 - Convert error! logging to warn! to avoid spurious stderr spamming from audioipc. r=kamidphish
authorMatthew Gregan <kinetik@flim.org>
Wed, 08 Nov 2017 16:20:48 +1300
changeset 443958 c0e806b7a992dc9e8f608df3e6380bce574eb791
parent 443957 574db20bdf3e8b013b3575fc154621213a6aa8a6
child 443959 13ec107f211922aec40d4993eef12690c54a0c36
push id1618
push userCallek@gmail.com
push dateThu, 11 Jan 2018 17:45:48 +0000
treeherdermozilla-release@882ca853e05a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskamidphish
bugs1409904
milestone58.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1409904 - Convert error! logging to warn! to avoid spurious stderr spamming from audioipc. r=kamidphish
media/audioipc/server/src/lib.rs
--- a/media/audioipc/server/src/lib.rs
+++ b/media/audioipc/server/src/lib.rs
@@ -611,17 +611,17 @@ impl Server {
         }
     }
 
     fn accept(&mut self, poll: &mut mio::Poll) -> Result<()> {
         debug!("Server accepting connection");
 
         let client_socket = match self.socket.accept() {
             Err(e) => {
-                error!("server accept error: {}", e);
+                warn!("server accept error: {}", e);
                 return Err(e.into());
             },
             Ok(None) => panic!("accept returned EAGAIN unexpectedly"),
             Ok(Some((socket, _))) => socket,
         };
 
         if !self.conns.has_available() {
             trace!(
@@ -668,24 +668,24 @@ impl Server {
         Ok(())
     }
 
     pub fn poll(&mut self, poll: &mut mio::Poll) -> Result<()> {
         let mut events = mio::Events::with_capacity(16);
 
         match poll.poll(&mut events, None) {
             Ok(_) => {},
-            Err(e) => error!("server poll error: {}", e),
+            Err(e) => warn!("server poll error: {}", e),
         }
 
         for event in events.iter() {
             match event.token() {
                 SERVER => {
                     if let Err(e) = self.accept(poll) {
-                        error!("server accept error: {}", e);
+                        warn!("server accept error: {}", e);
                     };
                 },
                 QUIT => {
                     info!("Quitting Audio Server loop");
                     bail!("quit");
                 },
                 token => {
                     trace!("token {:?} ready", token);