Bug 1446270 - Android/arm target should turn on crash reporter as default. r=froydnj
authorMakoto Kato <m_kato@ga2.so-net.ne.jp>
Fri, 16 Mar 2018 16:38:14 +0900
changeset 464844 bf807404eb8885b6811ef22069eb0b92f9ea470b
parent 464843 9659a30c4bb04e36661f5ac3d44a8d0b73173708
child 464845 b09ae094c0542194c212657923be635011387518
push id1728
push userjlund@mozilla.com
push dateMon, 18 Jun 2018 21:12:27 +0000
treeherdermozilla-release@c296fde26f5f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1446270
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1446270 - Android/arm target should turn on crash reporter as default. r=froydnj target value of Anndroid/arm is arm-unknown-linux-androideabi, so arm-*-linux* matches on android/arm and MOZ_CRASHREPORTER is unset as default option. Since taskcluster's build adds --enable-crashrepoter as default, we should set it as developer's default too. MozReview-Commit-ID: 8V6sWAN07F9
old-configure.in
--- a/old-configure.in
+++ b/old-configure.in
@@ -2826,24 +2826,26 @@ case $target in
 i?86-*-mingw*|x86_64-*-mingw*)
   MOZ_CRASHREPORTER=1
   ;;
 i?86-apple-darwin*|x86_64-apple-darwin*)
   if test -z "$MOZ_IOS"; then
     MOZ_CRASHREPORTER=1
   fi
   ;;
+*-android*|*-linuxandroid*)
+  dnl Android/arm is arm-unknown-linux-androideabi, so android condition should
+  dnl be before Linux condition
+  MOZ_CRASHREPORTER=1
+  ;;
 i?86-*-linux*|x86_64-*-linux*|arm-*-linux*)
   if test "$MOZ_ENABLE_GTK"; then
     MOZ_CRASHREPORTER=1
   fi
   ;;
-*-android*|*-linuxandroid*)
-  MOZ_CRASHREPORTER=1
-  ;;
 esac
 
 MOZ_ARG_DISABLE_BOOL(crashreporter,
 [  --disable-crashreporter Disable breakpad crash reporting],
     [MOZ_CRASHREPORTER=],
     [MOZ_CRASHREPORTER=F # Force enable breakpad])
 
 if test "$OS_ARCH" != "$HOST_OS_ARCH" -a "$OS_ARCH" != "WINNT" -a "$OS_ARCH" != "Darwin"; then