Bug 929896 - Make GTEST_CPP_SOURCES a StrictOrderingOnAppendList. r=mshal
authorMike Hommey <mh+mozilla@glandium.org>
Thu, 24 Oct 2013 07:59:50 +0900
changeset 166676 bf77633ddab06c137fc4008504cafe0524962024
parent 166675 b854380d2c359498be7c684a1e09784ed6ff4702
child 166677 56c3abf3f03093fbb638d3bb6ce15de743f7e12f
push id428
push userbbajaj@mozilla.com
push dateTue, 28 Jan 2014 00:16:25 +0000
treeherdermozilla-release@cd72a7ff3a75 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmshal
bugs929896
milestone27.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 929896 - Make GTEST_CPP_SOURCES a StrictOrderingOnAppendList. r=mshal
gfx/tests/gtest/moz.build
python/mozbuild/mozbuild/frontend/sandbox_symbols.py
--- a/gfx/tests/gtest/moz.build
+++ b/gfx/tests/gtest/moz.build
@@ -4,38 +4,38 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 MODULE = 'gfxtest'
 
 LIBRARY_NAME = 'gfxtest'
 
 GTEST_CPP_SOURCES += [
+    'TestAsyncPanZoomController.cpp',
+    'TestBufferRotation.cpp',
+    'TestColorNames.cpp',
+    'TestLayers.cpp',
+    'TestRegion.cpp',
+    'TestTextures.cpp',
+    'TestTiledLayerBuffer.cpp',
     # Hangs on linux in ApplyGdkScreenFontOptions
     #'gfxFontSelectionTest.cpp',
     'gfxSurfaceRefCountTest.cpp',
     # Test works but it doesn't assert anything
     #'gfxTextRunPerfTest.cpp',
     'gfxWordCacheTest.cpp',
-    'TestAsyncPanZoomController.cpp',
-    'TestLayers.cpp',
-    'TestTiledLayerBuffer.cpp',
-    'TestRegion.cpp',
-    'TestColorNames.cpp',
-    'TestTextures.cpp',
-    'TestBufferRotation.cpp',
 ]
 
 # Because of gkmedia on windows we wont find these
 # symbols in xul.dll.
 if CONFIG['MOZ_WIDGET_TOOLKIT'] != 'windows':
     GTEST_CPP_SOURCES += [
         'TestBase.cpp',
         'TestMoz2D.cpp',
+        'TestPoint.cpp',
         'TestRect.cpp',
-        'TestPoint.cpp',
         'TestScaling.cpp',
     ]
 
 LIBXUL_LIBRARY = True
 
 EXPORT_LIBRARY = True
 
--- a/python/mozbuild/mozbuild/frontend/sandbox_symbols.py
+++ b/python/mozbuild/mozbuild/frontend/sandbox_symbols.py
@@ -193,17 +193,17 @@ VARIABLES = {
 
     'GTEST_CMM_SOURCES': (StrictOrderingOnAppendList, list, [],
         """Sources for GTest unit tests to compile with the Objective C/C++ compiler.
 
         This variable contains a list of objective-C++ GTest unit test sources
         to compile.
         """, 'compile'),
 
-    'GTEST_CPP_SOURCES': (list, list, [],
+    'GTEST_CPP_SOURCES': (StrictOrderingOnAppendList, list, [],
         """C++ source files for GTest unit tests.
 
         This is a list of C++ GTest unit test sources. Entries must be files
         that exist. These generally have ``.cpp``, ``.cc``, or ``.cxx``
         extensions.
         """, 'compile'),
 
     'HOST_CPPSRCS': (StrictOrderingOnAppendList, list, [],