author | Ms2ger <ms2ger@gmail.com> |
Thu, 29 Mar 2012 23:09:06 +0200 | |
changeset 94358 | bee19c71bcef7665f2934f091ae715fad45cf3e0 |
parent 94357 | f28201b83cb40005c3ae7c88ac616dbdd4f0a970 |
child 94359 | dec46a6908cf2bea568475e0a47527af78cb5eb0 |
push id | 160 |
push user | lsblakk@mozilla.com |
push date | Fri, 13 Jul 2012 18:18:57 +0000 |
treeherder | mozilla-release@228ba1a111fc [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
reviewers | sicking |
bugs | 738654 |
milestone | 14.0a1 |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
--- a/content/base/public/nsINode.h +++ b/content/base/public/nsINode.h @@ -1508,18 +1508,18 @@ protected: * nodes. The aChildArray passed in should be the one for |this|. * * @param aIndex The index to remove at. * @param aNotify Whether to notify. * @param aKid The kid at aIndex. Must not be null. * @param aChildArray The child array to work with. * @param aMutationEvent whether to fire a mutation event for this removal. */ - nsresult doRemoveChildAt(PRUint32 aIndex, bool aNotify, nsIContent* aKid, - nsAttrAndChildArray& aChildArray); + void doRemoveChildAt(PRUint32 aIndex, bool aNotify, nsIContent* aKid, + nsAttrAndChildArray& aChildArray); /** * Most of the implementation of the nsINode InsertChildAt method. * Should only be called on document, element, and document fragment * nodes. The aChildArray passed in should be the one for |this|. * * @param aKid The child to insert. * @param aIndex The index to insert at.
--- a/content/base/src/nsDocument.cpp +++ b/content/base/src/nsDocument.cpp @@ -3525,20 +3525,19 @@ nsDocument::RemoveChildAt(PRUint32 aInde return NS_OK; } if (oldKid->IsElement()) { // Destroy the link map up front before we mess with the child list. DestroyElementMaps(); } - nsresult rv = - doRemoveChildAt(aIndex, aNotify, oldKid, mChildren); + doRemoveChildAt(aIndex, aNotify, oldKid, mChildren); mCachedRootElement = nsnull; - return rv; + return NS_OK; } PRInt32 nsDocument::GetNumberOfStyleSheets() const { return mStyleSheets.Count(); }
--- a/content/base/src/nsGenericElement.cpp +++ b/content/base/src/nsGenericElement.cpp @@ -3850,23 +3850,23 @@ nsINode::doInsertChildAt(nsIContent* aKi nsresult nsGenericElement::RemoveChildAt(PRUint32 aIndex, bool aNotify) { nsCOMPtr<nsIContent> oldKid = mAttrsAndChildren.GetSafeChildAt(aIndex); NS_ASSERTION(oldKid == GetChildAt(aIndex), "Unexpected child in RemoveChildAt"); if (oldKid) { - return doRemoveChildAt(aIndex, aNotify, oldKid, mAttrsAndChildren); + doRemoveChildAt(aIndex, aNotify, oldKid, mAttrsAndChildren); } return NS_OK; } -nsresult +void nsINode::doRemoveChildAt(PRUint32 aIndex, bool aNotify, nsIContent* aKid, nsAttrAndChildArray& aChildArray) { NS_PRECONDITION(aKid && aKid->GetNodeParent() == this && aKid == GetChildAt(aIndex) && IndexOf(aKid) == (PRInt32)aIndex, "Bogus aKid"); nsMutationGuard::DidMutate(); @@ -3883,18 +3883,16 @@ nsINode::doRemoveChildAt(PRUint32 aIndex aChildArray.RemoveChildAt(aIndex); if (aNotify) { nsNodeUtils::ContentRemoved(this, aKid, aIndex, previousSibling); } aKid->UnbindFromTree(); - - return NS_OK; } NS_IMETHODIMP nsGenericElement::GetTextContent(nsAString &aTextContent) { nsContentUtils::GetNodeTextContent(this, true, aTextContent); return NS_OK; }