No bug - Change the configuration of some properties for servo. r=me
authorEmilio Cobos Álvarez <emilio@crisal.io>
Sun, 29 Apr 2018 02:43:47 +0200
changeset 472312 be9164913cc69fbf6dcdbbab6c582a54faadc8b5
parent 472311 dd68a30f619116cdb8ca2f313de814f0b697f17f
child 472313 bc816979fee8908ee4fb26cc0c1504dd9a318b10
push id1728
push userjlund@mozilla.com
push dateMon, 18 Jun 2018 21:12:27 +0000
treeherdermozilla-release@c296fde26f5f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersme
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
No bug - Change the configuration of some properties for servo. r=me MozReview-Commit-ID: FxJQrXziRK0
servo/components/style/properties/longhand/position.mako.rs
--- a/servo/components/style/properties/longhand/position.mako.rs
+++ b/servo/components/style/properties/longhand/position.mako.rs
@@ -347,24 +347,24 @@ macro_rules! impl_align_conversions {
                           initial_value="computed::GridTemplateAreas::none()",
                           products="gecko",
                           animation_value_type="discrete",
                           spec="https://drafts.csswg.org/css-grid/#propdef-grid-template-areas")}
 
 ${helpers.predefined_type("column-gap",
                           "length::NonNegativeLengthOrPercentageOrNormal",
                           "Either::Second(Normal)",
-                          alias="grid-column-gap",
+                          alias="grid-column-gap" if product == "gecko" else "",
                           extra_prefixes="moz",
                           servo_pref="layout.columns.enabled",
                           spec="https://drafts.csswg.org/css-align-3/#propdef-column-gap",
                           animation_value_type="NonNegativeLengthOrPercentageOrNormal",
                           servo_restyle_damage = "reflow")}
 
 // no need for -moz- prefixed alias for this property
 ${helpers.predefined_type("row-gap",
                           "length::NonNegativeLengthOrPercentageOrNormal",
                           "Either::Second(Normal)",
                           alias="grid-row-gap",
-                          servo_pref="layout.columns.enabled",
+                          products="gecko",
                           spec="https://drafts.csswg.org/css-align-3/#propdef-row-gap",
                           animation_value_type="NonNegativeLengthOrPercentageOrNormal",
                           servo_restyle_damage = "reflow")}