Bug 1338027 - Fix RTL padding in the linear tabs layout. r=maliu,sebastian a=gchang
authorTom Klein <twointofive@gmail.com>
Wed, 08 Feb 2017 18:10:27 -0600
changeset 378702 bdd89262f426285de649c31b5dc7706981150a26
parent 378701 f97503c9caea474dcea727954e4ae62f68482e4d
child 378703 1e60fbfb7a056a09a5a7c91591f0d17326c9b604
push id1419
push userjlund@mozilla.com
push dateMon, 10 Apr 2017 20:44:07 +0000
treeherdermozilla-release@5e6801b73ef6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmaliu, sebastian, gchang
bugs1338027
milestone53.0a2
Bug 1338027 - Fix RTL padding in the linear tabs layout. r=maliu,sebastian a=gchang MozReview-Commit-ID: Lrljp1een4y
mobile/android/base/resources/layout/tabs_list_item_view.xml
--- a/mobile/android/base/resources/layout/tabs_list_item_view.xml
+++ b/mobile/android/base/resources/layout/tabs_list_item_view.xml
@@ -5,16 +5,19 @@
 
 <org.mozilla.gecko.tabs.TabsLayoutItemView xmlns:android="http://schemas.android.com/apk/res/android"
                                            style="@style/TabsItem"
                                            android:focusable="true"
                                            android:id="@+id/info"
                                            android:layout_width="match_parent"
                                            android:layout_height="wrap_content"
                                            android:paddingLeft="12dip"
+                                           android:paddingStart="12dip"
+                                           android:paddingRight="0dip"
+                                           android:paddingEnd="0dip"
                                            android:paddingTop="6dip"
                                            android:paddingBottom="6dip"
                                            android:background="@drawable/tab_row">
 
     <!-- We set state_private on this View dynamically in TabsListLayout. -->
     <org.mozilla.gecko.widget.TabThumbnailWrapper
             android:id="@+id/wrapper"
             android:layout_width="wrap_content"
@@ -33,17 +36,19 @@
     </org.mozilla.gecko.widget.TabThumbnailWrapper>
 
     <LinearLayout android:layout_width="0dip"
                   android:layout_height="match_parent"
                   android:orientation="vertical"
                   android:layout_weight="1.0"
                   android:paddingTop="4dip"
                   android:paddingLeft="8dip"
+                  android:paddingStart="8dip"
                   android:paddingRight="4dip"
+                  android:paddingEnd="4dip"
                   android:duplicateParentState="true">
 
         <TextView android:id="@+id/title"
                   android:layout_width="match_parent"
                   android:layout_height="0dip"
                   android:layout_weight="1.0"
                   style="@style/TabLayoutItemTextAppearance"
                   android:textColor="@color/tab_item_title"