Bug 1486674 - get rid of nsIDOMXULCheckboxElement, r=smaug
authorAlexander Surkov <surkov.alexander@gmail.com>
Thu, 30 Aug 2018 08:17:11 +0800
changeset 491777 bc6567e31d48dd62be7df4a9d11fd74621858b53
parent 491776 7d527975aa0e9ee49b01c3120f4738e254a4424f
child 491778 10c2d7ed3aaff4334d186739c2978dcb8f46226d
push id1815
push userffxbld-merge
push dateMon, 15 Oct 2018 10:40:45 +0000
treeherdermozilla-release@18d4c09e9378 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssmaug
bugs1486674
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1486674 - get rid of nsIDOMXULCheckboxElement, r=smaug
dom/interfaces/xul/moz.build
dom/interfaces/xul/nsIDOMXULCheckboxElement.idl
security/manager/pki/resources/content/clientauthask.js
toolkit/content/widgets/checkbox.xml
--- a/dom/interfaces/xul/moz.build
+++ b/dom/interfaces/xul/moz.build
@@ -4,17 +4,16 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 with Files("**"):
     BUG_COMPONENT = ("Core", "XUL")
 
 XPIDL_SOURCES += [
     'nsIDOMXULButtonElement.idl',
-    'nsIDOMXULCheckboxElement.idl',
     'nsIDOMXULCommandDispatcher.idl',
     'nsIDOMXULContainerElement.idl',
     'nsIDOMXULControlElement.idl',
     'nsIDOMXULDescriptionElement.idl',
     'nsIDOMXULLabeledControlEl.idl',
     'nsIDOMXULLabelElement.idl',
     'nsIDOMXULMenuListElement.idl',
     'nsIDOMXULMultSelectCntrlEl.idl',
deleted file mode 100644
--- a/dom/interfaces/xul/nsIDOMXULCheckboxElement.idl
+++ /dev/null
@@ -1,11 +0,0 @@
-/* -*- Mode: IDL; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
-/* This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
-
-#include "nsIDOMXULLabeledControlEl.idl"
-
-[scriptable, uuid(674965d9-aff4-411d-a382-7cb32c0f25a1)]
-interface nsIDOMXULCheckboxElement : nsIDOMXULLabeledControlElement {
-  attribute boolean checked;
-};
--- a/security/manager/pki/resources/content/clientauthask.js
+++ b/security/manager/pki/resources/content/clientauthask.js
@@ -46,17 +46,17 @@
 var bundle;
 /**
  * The array of certs the user can choose from.
  * @type nsIArray<nsIX509Cert>
  */
 var certArray;
 /**
  * The checkbox storing whether the user wants to remember the selected cert.
- * @type nsIDOMXULCheckboxElement
+ * @type Element checkbox, has to have |checked| property.
  */
 var rememberBox;
 
 function onLoad() {
   bundle = document.getElementById("pippki_bundle");
   let rememberSetting =
     Services.prefs.getBoolPref("security.remember_cert_checkbox_default_setting");
 
--- a/toolkit/content/widgets/checkbox.xml
+++ b/toolkit/content/widgets/checkbox.xml
@@ -18,17 +18,17 @@
     <content>
       <xul:image class="checkbox-check" xbl:inherits="checked,disabled"/>
       <xul:hbox class="checkbox-label-box" flex="1">
         <xul:image class="checkbox-icon" xbl:inherits="src"/>
         <xul:label class="checkbox-label" xbl:inherits="xbl:text=label,accesskey,crop" flex="1"/>
       </xul:hbox>
     </content>
 
-    <implementation implements="nsIDOMXULCheckboxElement">
+    <implementation>
       <method name="setChecked">
         <parameter name="aValue"/>
         <body>
         <![CDATA[
           var change = (aValue != (this.getAttribute("checked") == "true"));
           if (aValue)
             this.setAttribute("checked", "true");
           else