Bug 1457960 - P2. Don't make MediaDecoder::Seek virtual. r=bryce
authorJean-Yves Avenard <jyavenard@mozilla.com>
Mon, 30 Apr 2018 19:59:32 +0200
changeset 472543 bbe0de8d6ef96fb18793488cdaf97cf9c59d37bc
parent 472542 bbfe1fb6432d5c7798745e5d99090eade9526d9e
child 472544 f53ccf5c545c44c5aecfaa1c2b55b3d64414fcf8
push id1728
push userjlund@mozilla.com
push dateMon, 18 Jun 2018 21:12:27 +0000
treeherdermozilla-release@c296fde26f5f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbryce
bugs1457960
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1457960 - P2. Don't make MediaDecoder::Seek virtual. r=bryce It's unnecessary. MozReview-Commit-ID: Hau3nb9WLKe
dom/media/MediaDecoder.h
--- a/dom/media/MediaDecoder.h
+++ b/dom/media/MediaDecoder.h
@@ -129,17 +129,17 @@ public:
 
   // Return the time position in the video stream being
   // played measured in seconds.
   virtual double GetCurrentTime();
 
   // Seek to the time position in (seconds) from the start of the video.
   // If aDoFastSeek is true, we'll seek to the sync point/keyframe preceeding
   // the seek target.
-  virtual void Seek(double aTime, SeekTarget::Type aSeekType);
+  void Seek(double aTime, SeekTarget::Type aSeekType);
 
   // Initialize state machine and schedule it.
   nsresult InitializeStateMachine();
 
   // Start playback of a video. 'Load' must have previously been
   // called.
   virtual nsresult Play();