Bug 1563728 - Add a return statement to BiquadFilterNode::GetFrequencyResponse to fix bustage. rs=padenot
authorEmilio Cobos Álvarez <emilio@crisal.io>
Sat, 06 Jul 2019 10:44:45 +0200
changeset 544388 bb29c8eeb41c73b5ddafc4396ac65b1f41437790
parent 544387 72070e8f6b08dc6d8698c4a16ab1d4cf26ba7c65
child 544389 8a393a44cfd0d84c1dacc7da190b8138d5b031e4
push id2131
push userffxbld-merge
push dateMon, 26 Aug 2019 18:30:20 +0000
treeherdermozilla-release@b19ffb3ca153 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspadenot
bugs1563728
milestone69.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1563728 - Add a return statement to BiquadFilterNode::GetFrequencyResponse to fix bustage. rs=padenot CLOSED TREE
dom/media/webaudio/BiquadFilterNode.cpp
--- a/dom/media/webaudio/BiquadFilterNode.cpp
+++ b/dom/media/webaudio/BiquadFilterNode.cpp
@@ -306,16 +306,17 @@ void BiquadFilterNode::GetFrequencyRespo
                                             ErrorResult& aRv) {
   aFrequencyHz.ComputeLengthAndData();
   aMagResponse.ComputeLengthAndData();
   aPhaseResponse.ComputeLengthAndData();
 
   if (!(aFrequencyHz.Length() == aMagResponse.Length() &&
         aMagResponse.Length() == aPhaseResponse.Length())) {
     aRv.Throw(NS_ERROR_DOM_INVALID_ACCESS_ERR);
+    return;
   }
 
   uint32_t length = aFrequencyHz.Length();
   if (!length) {
     return;
   }
 
   auto frequencies = MakeUnique<float[]>(length);