Bug 1407432 - Remove unused builtins arg from Sandbox; r=froydnj
☠☠ backed out by 5ee7f274f84b ☠ ☠
authorMike Shal <mshal@mozilla.com>
Wed, 08 Nov 2017 19:58:28 -0500
changeset 444354 bacf04be0a480e4d7ea94de3c2677de3e0d5e10c
parent 444353 8d770908a5b9a3421294c93f8a34a14265674e9b
child 444355 828d43ec1b16edaac69c42f15561f26e209051f1
push id1618
push userCallek@gmail.com
push dateThu, 11 Jan 2018 17:45:48 +0000
treeherdermozilla-release@882ca853e05a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1407432
milestone58.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1407432 - Remove unused builtins arg from Sandbox; r=froydnj MozReview-Commit-ID: JVukxIg04AT
python/mozbuild/mozbuild/frontend/sandbox.py
--- a/python/mozbuild/mozbuild/frontend/sandbox.py
+++ b/python/mozbuild/mozbuild/frontend/sandbox.py
@@ -108,20 +108,20 @@ class Sandbox(dict):
         'None': None,
         'False': False,
         'True': True,
         'sorted': alphabetical_sorted,
         'int': int,
         'set': set,
     })
 
-    def __init__(self, context, builtins=None, finder=default_finder):
+    def __init__(self, context, finder=default_finder):
         """Initialize a Sandbox ready for execution.
         """
-        self._builtins = builtins or self.BUILTINS
+        self._builtins = self.BUILTINS
         dict.__setitem__(self, '__builtins__', self._builtins)
 
         assert isinstance(self._builtins, ReadOnlyDict)
         assert isinstance(context, Context)
 
         # Contexts are modeled as a stack because multiple context managers
         # may be active.
         self._active_contexts = [context]