Bug 1490937 - "Tab titles for selected tabs in modal dialogs have too little contrast" a=pascalc
authorDão Gottwald <dao+bmo>
Tue, 25 Sep 2018 07:38:00 +0300
changeset 492683 b94d1d0eaf9e5b062ee94b62e0456d06aedbd842
parent 492682 7a888f0923ee678ba61f3ffbe5fce672ed0c1322
child 492684 020d3140a05545cfe88da2edabe4831c69ce9db0
push id1815
push userffxbld-merge
push dateMon, 15 Oct 2018 10:40:45 +0000
treeherdermozilla-release@18d4c09e9378 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspascalc
bugs1490937
milestone63.0
Bug 1490937 - "Tab titles for selected tabs in modal dialogs have too little contrast" a=pascalc
toolkit/themes/osx/global/in-content/common.css
toolkit/themes/shared/in-content/common.inc.css
--- a/toolkit/themes/osx/global/in-content/common.css
+++ b/toolkit/themes/osx/global/in-content/common.css
@@ -6,16 +6,17 @@
 %include ../../../shared/in-content/common.inc.css
 
 xul|tabs {
   padding-right: 0;
   padding-left: 0;
 }
 
 xul|tab[visuallyselected] {
+  color: inherit !important;
   text-shadow: none;
 }
 
 xul|button[dlgtype="help"] {
   -moz-appearance: none;
   width: auto;
 }
 
--- a/toolkit/themes/shared/in-content/common.inc.css
+++ b/toolkit/themes/shared/in-content/common.inc.css
@@ -130,24 +130,25 @@ xul|tabpanels {
   color: inherit;
 }
 
 xul|tabs {
   margin-bottom: 15px;
   border-top: 1px solid var(--in-content-box-border-color);
   border-bottom: 1px solid var(--in-content-box-border-color);
   background-color: var(--in-content-page-background);
+  color: var(--in-content-tab-color);
 }
 
 xul|tab {
   -moz-appearance: none;
   margin-top: 0;
   padding: 4px 20px;
   min-height: 44px;
-  color: var(--in-content-tab-color);
+  color: inherit;
   background-color: var(--in-content-page-background);
   border-width: 0;
   /* !important overrides tabbox.css RTL and visuallyselected rules */
   border-radius: 0 !important;
   transition: background-color 50ms ease 0s;
 }
 
 xul|tab:hover {