Bug 1573124 - Updated identity popup security view heading to include domain name. r=nhnt11
authorPaul Zuehlcke <pzuhlcke@mozilla.com>
Mon, 26 Aug 2019 15:00:13 +0000
changeset 553804 b8c9f6b697f20e87c59e6cfad1d38232da90569c
parent 553803 6473a165521bcfb94176525ed6b89a7dbe511c35
child 553805 0109aabb60c568f1fd72b184d4794c505244be9a
push id2165
push userffxbld-merge
push dateMon, 14 Oct 2019 16:30:58 +0000
treeherdermozilla-release@0eae18af659f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnhnt11
bugs1573124
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1573124 - Updated identity popup security view heading to include domain name. r=nhnt11 Differential Revision: https://phabricator.services.mozilla.com/D41546
browser/base/content/browser-siteIdentity.js
browser/components/controlcenter/content/identityPanel.inc.xul
browser/locales/en-US/chrome/browser/browser.dtd
browser/locales/en-US/chrome/browser/browser.properties
--- a/browser/base/content/browser-siteIdentity.js
+++ b/browser/base/content/browser-siteIdentity.js
@@ -154,16 +154,22 @@ var gIdentityHandler = {
     ));
   },
   get _identityPopupMainViewHeaderLabel() {
     delete this._identityPopupMainViewHeaderLabel;
     return (this._identityPopupMainViewHeaderLabel = document.getElementById(
       "identity-popup-mainView-panel-header-span"
     ));
   },
+  get _identityPopupSecurityView() {
+    delete this._identityPopupSecurityView;
+    return (this._identityPopupSecurityView = document.getElementById(
+      "identity-popup-securityView"
+    ));
+  },
   get _identityPopupSecurityEVContentOwner() {
     delete this._identityPopupSecurityEVContentOwner;
     return (this._identityPopupSecurityEVContentOwner = document.getElementById(
       "identity-popup-security-ev-content-owner"
     ));
   },
   get _identityPopupContentOwner() {
     delete this._identityPopupContentOwner;
@@ -1067,16 +1073,23 @@ var gIdentityHandler = {
     }
 
     // Push the appropriate strings out to the UI.
     this._identityPopupMainViewHeaderLabel.textContent = gNavigatorBundle.getFormattedString(
       "identity.headerMainWithHost",
       [host]
     );
 
+    this._identityPopupSecurityView.setAttribute(
+      "title",
+      gNavigatorBundle.getFormattedString("identity.headerSecurityWithHost", [
+        host,
+      ])
+    );
+
     this._identityPopupSecurityEVContentOwner.textContent = gNavigatorBundle.getFormattedString(
       "identity.ev.contentOwner",
       [owner]
     );
 
     this._identityPopupContentOwner.textContent = owner;
     this._identityPopupContentSupp.textContent = supplemental;
     this._identityPopupContentVerif.textContent = verifier;
--- a/browser/components/controlcenter/content/identityPanel.inc.xul
+++ b/browser/components/controlcenter/content/identityPanel.inc.xul
@@ -86,17 +86,16 @@
                 label="&identity.clearSiteData;"
                 oncommand="gIdentityHandler.clearSiteData(event); gIdentityHandler.recordClick('clear_sitedata');"/>
       </vbox>
     </panelview>
 
     <!-- Security SubView -->
     <panelview id="identity-popup-securityView"
                role="document"
-               title="&identity.securityView.label2;"
                descriptionheightworkaround="true">
       <vbox class="identity-popup-security-content">
         <vbox class="identity-popup-security-connection">
           <description class="identity-popup-connection-not-secure"
                        when-connection="not-secure secure-cert-user-overridden">&identity.connectionNotSecureSecurityView;</description>
           <description class="identity-popup-connection-secure"
                        when-connection="secure secure-ev">&identity.connectionVerified3;</description>
         </vbox>
--- a/browser/locales/en-US/chrome/browser/browser.dtd
+++ b/browser/locales/en-US/chrome/browser/browser.dtd
@@ -665,20 +665,16 @@ you can use these alternative items. Oth
 <!-- LOCALIZATION NOTE (editBookmark.panel.width): width of the bookmark panel.
      Should be large enough to fully display the Done and Cancel/
      Remove Bookmark buttons. -->
 <!ENTITY editBookmark.panel.width                    "23em">
 <!ENTITY editBookmark.done.label                     "Done">
 <!ENTITY editBookmark.showForNewBookmarks.label       "Show editor when saving">
 <!ENTITY editBookmark.showForNewBookmarks.accesskey   "S">
 
-<!-- LOCALIZATION NOTE (identity.securityView.label2)
-     This is the header of the security subview in the Site Identity panel. -->
-<!ENTITY identity.securityView.label2 "Connection Security">
-
 <!ENTITY identity.connectionSecure2 "Connection Secure">
 <!ENTITY identity.connectionNotSecure "Connection Is Not Secure">
 <!ENTITY identity.connectionNotSecureSecurityView "You are not securely connected to this site.">
 <!ENTITY identity.connectionFile "This page is stored on your computer.">
 <!ENTITY identity.connectionVerified3 "You are securely connected to this site.">
 <!ENTITY identity.connectionInternal "This is a secure &brandShortName; page.">
 <!ENTITY identity.extensionPage "This page is loaded from an extension.">
 <!ENTITY identity.insecureLoginForms2 "Logins entered on this page could be compromised.">
--- a/browser/locales/en-US/chrome/browser/browser.properties
+++ b/browser/locales/en-US/chrome/browser/browser.properties
@@ -469,19 +469,20 @@ webauthn.cancel=Cancel
 webauthn.cancel.accesskey=c
 webauthn.proceed=Proceed
 webauthn.proceed.accesskey=p
 webauthn.anonymize=Anonymize anyway
 
 # Spoof Accept-Language prompt
 privacy.spoof_english=Changing your language setting to English will make you more difficult to identify and enhance your privacy. Do you want to request English language versions of web pages?
 
-# LOCALIZATION NOTE (identity.headerMainWithHost):
+# LOCALIZATION NOTE (identity.headerMainWithHost, identity.headerSecurityWithHost):
 # %S is the hostname of the site that is being displayed.
 identity.headerMainWithHost=Site Information for %S
+identity.headerSecurityWithHost=Connection Security for %S
 identity.identified.verifier=Verified by: %S
 identity.identified.verified_by_you=You have added a security exception for this site.
 identity.identified.state_and_country=%S, %S
 identity.ev.contentOwner=Site owned by: %S
 
 # LOCALIZATION NOTE (identity.notSecure.label):
 # Keep this string as short as possible, this is displayed in the URL bar
 # use a synonym for "safe" or "private" if "secure" is too long.