Bug 1521170 - Fix the test message in the use-returnValue.js test. r=Standard8
☠☠ backed out by 02b9e7149911 ☠ ☠
authorJared Wein <jwein@mozilla.com>
Tue, 22 Jan 2019 23:23:41 +0000
changeset 514926 b8b0f4d2fa2cbc951383d18f28f72a34a77d32a1
parent 514925 413e705328be4731589d78ec41a12ea9f5a2dfec
child 514927 9ec304cd5e28666c8d6a45e99d1a396785c72cfd
push id1953
push userffxbld-merge
push dateMon, 11 Mar 2019 12:10:20 +0000
treeherdermozilla-release@9c35dcbaa899 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersStandard8
bugs1521170
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1521170 - Fix the test message in the use-returnValue.js test. r=Standard8 Differential Revision: https://phabricator.services.mozilla.com/D17301
tools/lint/eslint/eslint-plugin-mozilla/tests/use-returnValue.js
--- a/tools/lint/eslint/eslint-plugin-mozilla/tests/use-returnValue.js
+++ b/tools/lint/eslint/eslint-plugin-mozilla/tests/use-returnValue.js
@@ -16,25 +16,25 @@ const ruleTester = new RuleTester({ pars
 // Tests
 // ------------------------------------------------------------------------------
 
 function invalidCode(code, methodName) {
   let message = `{Array/String}.${methodName} doesn't modify the instance in-place`;
   return {code, errors: [{message, type: "MemberExpression"}]};
 }
 
-ruleTester.run("use-ownerGlobal", rule, {
+ruleTester.run("use-returnValue", rule, {
   valid: [
     "a = foo.concat(bar)",
     "b = bar.concat([1,3,4])",
     "c = baz.concat()",
     "d = qux.join(' ')",
     "e = quux.slice(1)",
     "Int64.join(-0x80000001, 0)",
   ],
   invalid: [
-    invalidCode("foo.concat(bar)"),
-    invalidCode("bar.concat([1,3,4])"),
-    invalidCode("baz.concat()"),
-    invalidCode("qux.join(' ')"),
-    invalidCode("quux.slice(1)"),
+    invalidCode("foo.concat(bar)", "concat"),
+    invalidCode("bar.concat([1,3,4])", "concat"),
+    invalidCode("baz.concat()", "concat"),
+    invalidCode("qux.join(' ')", "join"),
+    invalidCode("quux.slice(1)", "slice"),
   ],
 });