Bug 1248784 - Followup to add requested comment. r=froydnj DONTBUILD
authorBobby Holley <bobbyholley@gmail.com>
Wed, 17 Feb 2016 10:16:47 -0800
changeset 322848 b8231765b22c6b62b31fa7e11706daae2b4cb086
parent 322847 5039eb1fa76cc1872f7c1372b5d8569188d36998
child 322849 a06c480cea1847feab79a1b4b2c1fec557527e84
push id1128
push userjlund@mozilla.com
push dateWed, 01 Jun 2016 01:31:59 +0000
treeherdermozilla-release@fe0d30de989d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1248784
milestone47.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1248784 - Followup to add requested comment. r=froydnj DONTBUILD
mfbt/RefPtr.h
--- a/mfbt/RefPtr.h
+++ b/mfbt/RefPtr.h
@@ -21,16 +21,19 @@ namespace mozilla {
 template<class T> class OwningNonNull;
 
 // Traditionally, RefPtr supports automatic refcounting of any pointer type
 // with AddRef() and Release() methods that follow the traditional semantics.
 //
 // This traits class can be specialized to operate on other pointer types. For
 // example, we specialize this trait for opaque FFI types that represent
 // refcounted objects in Rust.
+//
+// Given the use of ConstRemovingRefPtrTraits below, U should not be a const-
+// qualified type.
 template<class U>
 struct RefPtrTraits
 {
   static void AddRef(U* aPtr) {
     aPtr->AddRef();
   }
   static void Release(U* aPtr) {
     aPtr->Release();