Bug 1328373 (part 1) - Remove mozilla_sampler_save. r=mstange.
authorNicholas Nethercote <nnethercote@mozilla.com>
Thu, 19 Jan 2017 08:07:50 +1100
changeset 377368 b7baa1086a601d3e7a11e2ea7f853ce55529429f
parent 377367 868ebc11e44f9305d82fe569fa798ca366a6f9d0
child 377369 c93c8b83e929b1752bb8b886de2d8d30f307842a
push id1419
push userjlund@mozilla.com
push dateMon, 10 Apr 2017 20:44:07 +0000
treeherdermozilla-release@5e6801b73ef6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmstange
bugs1328373
milestone53.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1328373 (part 1) - Remove mozilla_sampler_save. r=mstange. It's unused.
tools/profiler/core/platform.cpp
tools/profiler/public/GeckoProfilerFunc.h
--- a/tools/profiler/core/platform.cpp
+++ b/tools/profiler/core/platform.cpp
@@ -602,29 +602,16 @@ void mozilla_sampler_shutdown()
   stack->deref();
   tlsPseudoStack.set(nullptr);
 
 #ifdef MOZ_TASK_TRACER
   mozilla::tasktracer::ShutdownTaskTracer();
 #endif
 }
 
-void mozilla_sampler_save()
-{
-  GeckoSampler *t = tlsTicker.get();
-  if (!t) {
-    return;
-  }
-
-  t->RequestSave();
-  // We're on the main thread already so we don't
-  // have to wait to handle the save request.
-  t->HandleSaveRequest();
-}
-
 mozilla::UniquePtr<char[]> mozilla_sampler_get_profile(double aSinceTime)
 {
   GeckoSampler *t = tlsTicker.get();
   if (!t) {
     return nullptr;
   }
 
   return t->ToJSON(aSinceTime);
--- a/tools/profiler/public/GeckoProfilerFunc.h
+++ b/tools/profiler/public/GeckoProfilerFunc.h
@@ -56,18 +56,16 @@ bool mozilla_sampler_is_active();
 bool mozilla_sampler_feature_active(const char* aName);
 
 void mozilla_sampler_responsiveness(const mozilla::TimeStamp& time);
 
 void mozilla_sampler_frame_number(int frameNumber);
 
 const double* mozilla_sampler_get_responsiveness();
 
-void mozilla_sampler_save();
-
 mozilla::UniquePtr<char[]> mozilla_sampler_get_profile(double aSinceTime);
 
 JSObject *mozilla_sampler_get_profile_data(JSContext* aCx, double aSinceTime);
 void mozilla_sampler_get_profile_data_async(double aSinceTime,
                                             mozilla::dom::Promise* aPromise);
 MOZ_EXPORT
 void mozilla_sampler_save_profile_to_file_async(double aSinceTime,
                                                 const char* aFileName);