Bug 1519791 - Remove unused --toolbarbutton*-border-color variables. r=ntim
authorGarvit Khatri <garvitdelhi@gmail.com>
Tue, 22 Jan 2019 10:42:47 +0100
changeset 514820 b78ecfce1c782db32e171fc0854f41f886bcb8c0
parent 514819 8c16a97e50ba68ab012048e7c9735d5d3e7c7ee2
child 514821 ed955b30c2f0fc92dbb4844d4fe8a868ee8378d3
push id1953
push userffxbld-merge
push dateMon, 11 Mar 2019 12:10:20 +0000
treeherdermozilla-release@9c35dcbaa899 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersntim
bugs1519791
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1519791 - Remove unused --toolbarbutton*-border-color variables. r=ntim
devtools/client/jsonview/css/toolbar.css
devtools/client/themes/common.css
devtools/client/themes/toolbox.css
devtools/client/themes/variables.css
--- a/devtools/client/jsonview/css/toolbar.css
+++ b/devtools/client/jsonview/css/toolbar.css
@@ -14,29 +14,27 @@
   background: var(--theme-toolbar-background);
   border-bottom: 1px solid var(--theme-splitter-color);
 }
 
 .toolbar .btn {
   margin-inline-start: 5px;
   color: var(--theme-body-color);
   background: var(--toolbarbutton-background);
-  border: 1px solid var(--toolbarbutton-border-color);
+  border: none;
   text-decoration: none;
   display: inline-block;
   text-align: center;
   white-space: nowrap;
   vertical-align: middle;
   cursor: pointer;
   -moz-user-select: none;
-  padding: 0 2px;
+  padding: 0 3px;
   border-radius: 2px;
 }
 
 .toolbar .btn:hover {
   background: var(--toolbarbutton-hover-background);
-  border-color: var(--toolbarbutton-hover-border-color);
 }
 
 .toolbar .btn:not([disabled]):hover:active {
   background-color: var(--theme-selection-background-hover);
 }
-
--- a/devtools/client/themes/common.css
+++ b/devtools/client/themes/common.css
@@ -276,23 +276,23 @@ checkbox:-moz-focusring {
 }
 
 /* Toolbar buttons */
 .devtools-menulist,
 .devtools-toolbarbutton,
 .devtools-button {
   -moz-appearance: none;
   background: transparent;
-  border: 1px solid var(--toolbarbutton-border-color);
+  border: none;
   border-radius: 2px;
   color: var(--theme-body-color);
   transition: background-color 0.05s ease-in-out;
   -moz-box-align: center;
   text-shadow: none;
-  padding: 1px;
+  padding: 2px;
   margin: 1px;
 
   /* Button text should not wrap on multiple lines */
   white-space: nowrap;
 }
 
 /* Remove system form border from devtools-button. */
 .devtools-button::-moz-focus-inner {
@@ -378,17 +378,16 @@ checkbox:-moz-focusring {
 /* Selectable button which is unchecked. */
 
 .devtools-button:not(:empty):not(:disabled):not(.checked):hover,
 .devtools-toolbarbutton[label]:not(:-moz-any([checked=true],[disabled])):hover,
 .devtools-button:empty:not(:disabled):-moz-any(:hover:active,.checked),
 .devtools-toolbarbutton:not([label]):-moz-any([checked],[open],:hover:active),
 .devtools-button[aria-haspopup="menu"][aria-expanded="true"] {
   background-color: var(--toolbarbutton-hover-background);
-  border-color: var(--toolbarbutton-hover-border-color);
 }
 
 .devtools-button:not(:empty):not(.checked):not(:disabled):hover:active,
 .devtools-toolbarbutton:not(:-moz-any([checked=true],[disabled]))[label]:hover:active {
   background-color: var(--theme-selection-background-hover);
 }
 
 .devtools-button:not(:empty):not(.checked):not(:disabled):focus,
@@ -398,17 +397,16 @@ checkbox:-moz-focusring {
 }
 
 /* Selectable button which is checked. */
 
 .devtools-toolbarbutton:not([disabled])[label][checked=true],
 .devtools-toolbarbutton:not([disabled])[label][open],
 .devtools-button:not(:empty).checked {
   background: var(--toolbarbutton-checked-background);
-  border-color: var(--toolbarbutton-checked-border-color);
   color: var(--toolbarbutton-checked-color);
 }
 
 .devtools-toolbarbutton:not([disabled])[label][checked=true]:focus,
 .devtools-toolbarbutton:not([disabled])[label][open]:focus,
 .devtools-button:not(:empty).checked:focus {
   background-color: var(--toolbarbutton-checked-focus-background);
 }
--- a/devtools/client/themes/toolbox.css
+++ b/devtools/client/themes/toolbox.css
@@ -237,19 +237,17 @@
 }
 
 /* Command buttons */
 
 .command-button,
 #toolbox-controls > button,
 .toolbox-tabs-wrapper .tools-chevron-menu {
   /* !important is needed to override .devtools-button rules in common.css */
-  padding: 0 !important;
   margin: 0 !important;
-  border: none !important;
   border-radius: 0 !important;
   position: relative;
   min-width: 26px;
 }
 
 #command-button-pick {
   min-width: 32px;
 }
--- a/devtools/client/themes/variables.css
+++ b/devtools/client/themes/variables.css
@@ -191,24 +191,21 @@
   --theme-code-font-size: 11px;
 
   /* For accessibility purposes we want to enhance the focus styling. This
    * should improve keyboard navigation usability. */
   --theme-focus-outline: 1px dotted var(--theme-focus-outline-color);
   --theme-focus-box-shadow-textbox: 0 0 0 1px var(--theme-textbox-box-shadow);
 
   --toolbarbutton-background: var(--theme-toolbar-hover);
-  --toolbarbutton-border-color: transparent;
   --toolbarbutton-hover-background: var(--theme-toolbar-hover);
-  --toolbarbutton-hover-border-color: var(--toolbarbutton-border-color);
   --toolbarbutton-focus-background: var(--theme-selection-focus-background);
   --toolbarbutton-focus-color: var(--theme-selection-focus-color);
   --toolbarbutton-checked-background: var(--theme-selection-background);
   --toolbarbutton-checked-color: var(--theme-selection-color);
-  --toolbarbutton-checked-border-color: var(--toolbarbutton-border-color);
   --toolbarbutton-checked-focus-background: var(--blue-60);
 
   /* The photon animation curve */
   --animation-curve: cubic-bezier(.07,.95,0,1);
 
   /* Firefox Colors CSS Variables v1.0.3
    * Colors are taken from: https://github.com/FirefoxUX/design-tokens
    * Some intermediate colors were added (names ending in '5').