Bug 1431129 - Remove no-mixed-spaces-and-tabs from the ESLint config, since no-tabs disallows tabs anyway. r=mossop.
authorMark Banner <standard8@mozilla.com>
Thu, 18 Jan 2018 10:03:02 +0000
changeset 454312 b7899ec5d5f8b1a4195be85d23074d19ef8d4bb5
parent 454311 f7f3280ea84a5933e3a8484d73ee600f04396e9b
child 454313 e8f753ce0cfb8d6aae534bab30ee6f4089bf5f55
push id1648
push usermtabara@mozilla.com
push dateThu, 01 Mar 2018 12:45:47 +0000
treeherdermozilla-release@cbb9688c2eeb [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmossop
bugs1431129
milestone59.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1431129 - Remove no-mixed-spaces-and-tabs from the ESLint config, since no-tabs disallows tabs anyway. r=mossop. MozReview-Commit-ID: 395itqTz9T8
tools/lint/eslint/eslint-plugin-mozilla/lib/configs/recommended.js
--- a/tools/lint/eslint/eslint-plugin-mozilla/lib/configs/recommended.js
+++ b/tools/lint/eslint/eslint-plugin-mozilla/lib/configs/recommended.js
@@ -258,18 +258,18 @@ module.exports = {
     "no-labels": "error",
 
     // Disallow unnecessary nested blocks
     "no-lone-blocks": "error",
 
     // No single if block inside an else block
     "no-lonely-if": "error",
 
-    // No mixing spaces and tabs in indent
-    "no-mixed-spaces-and-tabs": ["error", "smart-tabs"],
+    // no-tabs disallows tabs completely.
+    // "no-mixed-spaces-and-tabs": "error",
 
     // No unnecessary spacing
     "no-multi-spaces": ["error", { exceptions: {
       "ArrayExpression": true,
       "AssignmentExpression": true,
       "ObjectExpression": true,
       "VariableDeclarator": true
     } }],